New issue
Advanced search Search tips

Issue 750946 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug

Blocking:
issue 743296



Sign in to add a comment

Fuchsia: stub out font and theme support

Project Member Reported by kmarshall@chromium.org, Aug 1 2017

Issue description

Stub out the platform specific implementations of abstract font and theme classes, e.g. FontPlatformData, LayoutTheme, FontCache, etc. Ideally the stubs are structured in such a way that they can be used a non-headless manner sometime in the future.

See the headless port doc (https://docs.google.com/document/d/18qh1MRMKs8O5bmHp2nCNg0WJi1YyDs8-cu_Pxq76174/edit#) for a list of porting candidates.
 

Comment 1 by e...@chromium.org, Aug 1 2017

Components: -Blink>Fonts
Not a bug and not a task for the layout team. Removing Blink>Fonts label as part of triage process.
Owner: scottmg@chromium.org
Status: Started (was: Untriaged)
(this came up in trying to get the debug bot linking, so might as well do it now)

Comment 3 by w...@chromium.org, Aug 1 2017

Blocking: 743296
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8590523e8d1b7918834e0b19b2ea2c1a31813c8a

commit 8590523e8d1b7918834e0b19b2ea2c1a31813c8a
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 02 18:08:53 2017

fuchsia: Stub Screen

Fuchsia is initially trying to get a headless build up and
running so a full Screen implementation is unnecessary, other
than to be able to link.

Bug:  750946 ,  743296 
Change-Id: Ib6333a304deacbd22d3f1b1f3af8fc9ca063bb15
Reviewed-on: https://chromium-review.googlesource.com/596949
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491436}
[modify] https://crrev.com/8590523e8d1b7918834e0b19b2ea2c1a31813c8a/ui/display/BUILD.gn
[add] https://crrev.com/8590523e8d1b7918834e0b19b2ea2c1a31813c8a/ui/display/screen_fuchsia.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0be8db5ffe047a1092145c31e4612ef3d44e7d57

commit 0be8db5ffe047a1092145c31e4612ef3d44e7d57
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 02 18:10:29 2017

fuchsia: Stub ui/gfx font methods

The Fuchsia build is initially trying to get a headless build
up and running, so ui/gfx/font is unnecessary currently, other
than to link.

Bug:  750946 
Change-Id: I39607a4dd78d73049d1c33c53e907fdfb7f3cf9c
Reviewed-on: https://chromium-review.googlesource.com/596838
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491437}
[modify] https://crrev.com/0be8db5ffe047a1092145c31e4612ef3d44e7d57/ui/gfx/BUILD.gn
[add] https://crrev.com/0be8db5ffe047a1092145c31e4612ef3d44e7d57/ui/gfx/font_fallback_fuchsia.cc
[add] https://crrev.com/0be8db5ffe047a1092145c31e4612ef3d44e7d57/ui/gfx/font_render_params_fuchsia.cc
[add] https://crrev.com/0be8db5ffe047a1092145c31e4612ef3d44e7d57/ui/gfx/platform_font_fuchsia.cc

Working on NativeTheme now.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8c97b63a2a086a82cf822fa115473b43a471605

commit a8c97b63a2a086a82cf822fa115473b43a471605
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 03 03:08:43 2017

Add LayoutThemeFuchsia theme stub to Blink.

Add LayoutThemeFuchsia theme stub to Blink.
The theme is necessary because no LayoutTheme* files are currently
built when is_fuchsia=true.

Bug:  750946 
Change-Id: Iab9cdf66856164309882239e643c2006f200d669
Reviewed-on: https://chromium-review.googlesource.com/599248
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491626}
[modify] https://crrev.com/a8c97b63a2a086a82cf822fa115473b43a471605/third_party/WebKit/Source/core/layout/BUILD.gn
[add] https://crrev.com/a8c97b63a2a086a82cf822fa115473b43a471605/third_party/WebKit/Source/core/layout/LayoutThemeFuchsia.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2dd1ab90fc5c08e2cc4cf96ed124e0ab07e76d8

commit d2dd1ab90fc5c08e2cc4cf96ed124e0ab07e76d8
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Sat Aug 05 00:49:00 2017

Add Fuchsia stub implementation for RenderView.

Add Fuchsia stub implementation for RenderView.

Bug:  750946 
Change-Id: Ie097e996e16d15a7603469f7a5a814afd4ca027b
Reviewed-on: https://chromium-review.googlesource.com/601129
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492200}
[modify] https://crrev.com/d2dd1ab90fc5c08e2cc4cf96ed124e0ab07e76d8/content/renderer/BUILD.gn
[add] https://crrev.com/d2dd1ab90fc5c08e2cc4cf96ed124e0ab07e76d8/content/renderer/render_view_fuchsia.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b07077bc0f186f3f7a4f1a5bffc210d076ee956c

commit b07077bc0f186f3f7a4f1a5bffc210d076ee956c
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Sat Aug 05 01:22:40 2017

Add Fuchsia platform font and text stubs for Blink.

Add Fuchsia platform font and text stubs for Blink.
These stubs are just placeholders used to get a headless build up and
running. The bodies will be filled once the porting effort is ready
for UI code.

Bug:  750946 
Change-Id: I73b1415f6e66b7cc8e291c2cb4ff486a92c7d4a9
Reviewed-on: https://chromium-review.googlesource.com/601127
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492207}
[modify] https://crrev.com/b07077bc0f186f3f7a4f1a5bffc210d076ee956c/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/b07077bc0f186f3f7a4f1a5bffc210d076ee956c/third_party/WebKit/Source/platform/fonts/fuchsia/FontCacheFuchsia.cpp
[add] https://crrev.com/b07077bc0f186f3f7a4f1a5bffc210d076ee956c/third_party/WebKit/Source/platform/fonts/fuchsia/FontPlatformDataFuchsia.cpp
[add] https://crrev.com/b07077bc0f186f3f7a4f1a5bffc210d076ee956c/third_party/WebKit/Source/platform/text/fuchsia/HyphenationFuchsia.cpp

Comment 10 by w...@chromium.org, Dec 8 2017

Status: Fixed (was: Started)

Sign in to add a comment