New issue
Advanced search Search tips

Issue 750943 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Feature



Sign in to add a comment

Fuchsia: get GL working on headless shell

Project Member Reported by kmarshall@chromium.org, Aug 1 2017

Issue description

Tracking bug for getting unblocking GL support under Fuchsia Headless.

Explore how we might best satisfy this dependency: e.g. use a null renderer; use software rendering (Swiftshader); or suppress input from the compositor?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5ea6ad9b7b5af521c634c6461227c619b6728a1

commit d5ea6ad9b7b5af521c634c6461227c619b6728a1
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Aug 09 14:39:17 2017

Fuchsia: use Ozone native widget types.

Fuchsia is initially being ported to Headless/Ozone, so we should use
its widget types for typesafe compatibility with the rest of Ozone/Aura.


Bug:  750943 
Change-Id: Ie39754f0c377b7ddbee5eda392437ee34765b723
Reviewed-on: https://chromium-review.googlesource.com/606551
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492971}
[modify] https://crrev.com/d5ea6ad9b7b5af521c634c6461227c619b6728a1/ui/gfx/native_widget_types.h

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dcacdc0662ca4aba17c07903ac2725c562eb78e

commit 9dcacdc0662ca4aba17c07903ac2725c562eb78e
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 17:24:23 2017

Revert "Fuchsia: use Ozone native widget types."

This reverts commit d5ea6ad9b7b5af521c634c6461227c619b6728a1.

Reason for revert: Failing compile started at https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/8559 .

Original change's description:
> Fuchsia: use Ozone native widget types.
> 
> Fuchsia is initially being ported to Headless/Ozone, so we should use
> its widget types for typesafe compatibility with the rest of Ozone/Aura.
> 
> 
> Bug:  750943 
> Change-Id: Ie39754f0c377b7ddbee5eda392437ee34765b723
> Reviewed-on: https://chromium-review.googlesource.com/606551
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492971}

TBR=thakis@chromium.org,kmarshall@chromium.org

Change-Id: I91fc95b1413516c08eaf80379323643826ea53a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  750943 
Reviewed-on: https://chromium-review.googlesource.com/608801
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493037}
[modify] https://crrev.com/9dcacdc0662ca4aba17c07903ac2725c562eb78e/ui/gfx/native_widget_types.h

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b90efc3352fcc6d9a6160fb39232ad26fad1659

commit 6b90efc3352fcc6d9a6160fb39232ad26fad1659
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 21:28:07 2017

fuchsia: flip on ozone and aura by default

Bug:  746674 ,  750943 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie1a1bbc4f8e8094d164c55ea5ce05de3159a7cb2
Reviewed-on: https://chromium-review.googlesource.com/609086
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: John Bauman <jbauman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493143}
[modify] https://crrev.com/6b90efc3352fcc6d9a6160fb39232ad26fad1659/build/config/ui.gni
[modify] https://crrev.com/6b90efc3352fcc6d9a6160fb39232ad26fad1659/third_party/khronos/EGL/eglplatform.h
[modify] https://crrev.com/6b90efc3352fcc6d9a6160fb39232ad26fad1659/third_party/khronos/README.chromium
[modify] https://crrev.com/6b90efc3352fcc6d9a6160fb39232ad26fad1659/ui/base/material_design/material_design_controller.cc
[modify] https://crrev.com/6b90efc3352fcc6d9a6160fb39232ad26fad1659/ui/ozone/common/gl_ozone_osmesa.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef5e0039b7333228ef69ce75c6a73ac797730d3d

commit ef5e0039b7333228ef69ce75c6a73ac797730d3d
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 21:36:22 2017

Revert "Revert "Fuchsia: use Ozone native widget types.""

This reverts commit 9dcacdc0662ca4aba17c07903ac2725c562eb78e.

Reason for revert: ozone and aura are on now for fuchsia, should be ok to reland.

Original change's description:
> Revert "Fuchsia: use Ozone native widget types."
> 
> This reverts commit d5ea6ad9b7b5af521c634c6461227c619b6728a1.
> 
> Reason for revert: Failing compile started at https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/8559 .
> 
> Original change's description:
> > Fuchsia: use Ozone native widget types.
> > 
> > Fuchsia is initially being ported to Headless/Ozone, so we should use
> > its widget types for typesafe compatibility with the rest of Ozone/Aura.
> > 
> > 
> > Bug:  750943 
> > Change-Id: Ie39754f0c377b7ddbee5eda392437ee34765b723
> > Reviewed-on: https://chromium-review.googlesource.com/606551
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#492971}
> 
> TBR=thakis@chromium.org,kmarshall@chromium.org
> 
> Change-Id: I91fc95b1413516c08eaf80379323643826ea53a4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  750943 
> Reviewed-on: https://chromium-review.googlesource.com/608801
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Commit-Queue: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#493037}

TBR=thakis@chromium.org,kmarshall@chromium.org,scottmg@chromium.org

Change-Id: I59e7c83f0f8eac17e32c87a88338f7b62502f58a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  750943 
Reviewed-on: https://chromium-review.googlesource.com/609362
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493147}
[modify] https://crrev.com/ef5e0039b7333228ef69ce75c6a73ac797730d3d/ui/gfx/native_widget_types.h

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9d6f8257f4fa30c9a544b5fd6f2635d5280f459

commit e9d6f8257f4fa30c9a544b5fd6f2635d5280f459
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Aug 09 22:57:09 2017

Fuchsia: remove concrete GL impls from Headless surface factory

The initial headless port of Fuchsia runs with the GPU process
disabled, so the GL systems are never spun up.


Bug:  750943 
Change-Id: Iadfa1a4b131f8465938765e0c5abba33f12b18c7
Reviewed-on: https://chromium-review.googlesource.com/606561
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493166}
[modify] https://crrev.com/e9d6f8257f4fa30c9a544b5fd6f2635d5280f459/ui/ozone/platform/headless/headless_surface_factory.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03cda649a1b78381d2f9e9419882477f1a30cce6

commit 03cda649a1b78381d2f9e9419882477f1a30cce6
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Aug 16 22:27:05 2017

Fuchsia: add stubbed implementations of some GPU methods.

This CL stubs out methods to remove dependencies on GPU-specific
functionality that isn't ready for porting yet.

The initial stage of the Fuchsia port will run Chrome headless with
the GPU process disabled, so these codepaths shouldn't be hit
in practice - the stubs are there so the headless shell can
compile and link properly.


Bug:  750943 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id0a100452cf715358ddf9faf7a256fc0f6244c01
Reviewed-on: https://chromium-review.googlesource.com/615843
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: John Bauman <jbauman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494979}
[modify] https://crrev.com/03cda649a1b78381d2f9e9419882477f1a30cce6/gpu/config/gpu_info_collector_fuchsia.cc
[modify] https://crrev.com/03cda649a1b78381d2f9e9419882477f1a30cce6/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/03cda649a1b78381d2f9e9419882477f1a30cce6/gpu/ipc/service/gpu_command_buffer_stub.cc
[modify] https://crrev.com/03cda649a1b78381d2f9e9419882477f1a30cce6/gpu/ipc/service/gpu_init.cc

Comment 7 by w...@chromium.org, Dec 8 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment