New issue
Advanced search Search tips

Issue 750941 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 713830



Sign in to add a comment

Customize Welcome Apps texts based on device type

Project Member Reported by wzang@chromium.org, Aug 1 2017

Issue description

Certain texts of the Welcome Apps should be shown only when device is Assistant capable. The specs are:
https://docs.google.com/presentation/d/1iqxdoxEi_EpmUOUpL6mTxeToo-i9CV1S2yvdS04Cxu8/edit#slide=id.g1f81334fbb_0_0

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93810102c790b3712faee298482539bfff693e49

commit 93810102c790b3712faee298482539bfff693e49
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Aug 01 22:10:40 2017

Update Welcome App texts based on voice interaction status

The texts of the first step (launcher) of Welcome App should be
customized based on if voice interaction (Assistant) is enabled.

Bug:  750941 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2d53c2e5c8e6e0d579f1564c7793d27fde96d172
Reviewed-on: https://chromium-review.googlesource.com/595111
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491129}
[modify] https://crrev.com/93810102c790b3712faee298482539bfff693e49/chrome/browser/resources/chromeos/first_run/app_list_step.html
[modify] https://crrev.com/93810102c790b3712faee298482539bfff693e49/chrome/browser/resources/chromeos/first_run/first_run.js
[modify] https://crrev.com/93810102c790b3712faee298482539bfff693e49/chrome/browser/resources/chromeos/first_run/step.js
[modify] https://crrev.com/93810102c790b3712faee298482539bfff693e49/chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc

Comment 2 by wzang@chromium.org, Aug 1 2017

Status: Fixed (was: Assigned)

Comment 3 by wzang@chromium.org, Aug 8 2017

Labels: Merge-Request-61
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 8 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by ketakid@google.com, Aug 8 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c8e16bd2b7998d4eb17c4eba8d08126f39932be

commit 0c8e16bd2b7998d4eb17c4eba8d08126f39932be
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Aug 10 01:07:09 2017

Update Welcome App texts based on voice interaction status

The texts of the first step (launcher) of Welcome App should be
customized based on if voice interaction (Assistant) is enabled.

TBR=wzang@chromium.org

(cherry picked from commit 93810102c790b3712faee298482539bfff693e49)

Bug:  750941 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2d53c2e5c8e6e0d579f1564c7793d27fde96d172
Reviewed-on: https://chromium-review.googlesource.com/595111
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491129}
Reviewed-on: https://chromium-review.googlesource.com/609535
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#423}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/0c8e16bd2b7998d4eb17c4eba8d08126f39932be/chrome/browser/resources/chromeos/first_run/app_list_step.html
[modify] https://crrev.com/0c8e16bd2b7998d4eb17c4eba8d08126f39932be/chrome/browser/resources/chromeos/first_run/first_run.js
[modify] https://crrev.com/0c8e16bd2b7998d4eb17c4eba8d08126f39932be/chrome/browser/resources/chromeos/first_run/step.js
[modify] https://crrev.com/0c8e16bd2b7998d4eb17c4eba8d08126f39932be/chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment