New issue
Advanced search Search tips

Issue 750940 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Feature



Sign in to add a comment

Fuchsia: port WebRTC and its dependencies

Project Member Reported by kmarshall@chromium.org, Aug 1 2017

Issue description

Tracking bug for porting WebRTC to Fuchsia.

We might be able to postpone this task by disabling webrtc using the "enable_webrtc" flag.

Note that "enable_webrtc" flag isn't respected across the entire codebase, and some BUILD.gn files might need fixing. See the "headless port findings" doc and CL for more information: 
https://docs.google.com/document/d/18qh1MRMKs8O5bmHp2nCNg0WJi1YyDs8-cu_Pxq76174/edit#
 
Status: Assigned (was: Untriaged)
Changing to "Assigned" since there is an owner.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cabcdc2844ff77a54a0bfcb172c2a96c5ae686f

commit 8cabcdc2844ff77a54a0bfcb172c2a96c5ae686f
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Dec 08 21:56:53 2017

Roll usrsctp f4819e1 -> 0e07626

Last version of usrsctp builds on Fuchsia.
Full change log: https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+/f4819e1b177f7bfdd761c147f5a649b9f1a78c06..0e076261b832121cf120ddc04aaff87ac3a34d30

Bug:  750940 
Change-Id: I337ea4e1321a4ff6f0638a01d4129eb15a982f60
Reviewed-on: https://chromium-review.googlesource.com/815732
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: James Robinson <jamesr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522893}
[modify] https://crrev.com/8cabcdc2844ff77a54a0bfcb172c2a96c5ae686f/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c53d6b18305f616aced869c3174d0a8d69494bb

commit 7c53d6b18305f616aced869c3174d0a8d69494bb
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Dec 11 19:15:29 2017

Update WebRTC tests to use ScopedTaskEnvironment

Some WebRTC tests were failing when executed in the same process with
others because they were leaving base::TaskScheduler intialized. Updated
WebRTC tests to use ScopedTaskEnvironment to ensure that TaskScheduler
is destroyed.

Bug:  750940 
Change-Id: I7420aba0c2a990ecfd2fd44df7ac014a76a73ba7
Reviewed-on: https://chromium-review.googlesource.com/817525
Reviewed-by: Per Kjellander <perkj@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523161}
[modify] https://crrev.com/7c53d6b18305f616aced869c3174d0a8d69494bb/content/renderer/media/webrtc/webrtc_media_stream_adapter_map_unittest.cc
[modify] https://crrev.com/7c53d6b18305f616aced869c3174d0a8d69494bb/content/renderer/media/webrtc/webrtc_media_stream_track_adapter_map_unittest.cc
[modify] https://crrev.com/7c53d6b18305f616aced869c3174d0a8d69494bb/content/renderer/media/webrtc/webrtc_media_stream_track_adapter_unittest.cc
[modify] https://crrev.com/7c53d6b18305f616aced869c3174d0a8d69494bb/content/renderer/media/webrtc/webrtc_set_remote_description_observer_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/6acefdb70a0b6d86b4f5682f1a28257466efef9c

commit 6acefdb70a0b6d86b4f5682f1a28257466efef9c
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Dec 12 23:37:28 2017

Fixes to build WebRTC for Fuchsia

1. Added WEBRTC_FUCHSIA define.
2. Added PlatformThreadId typedef for Fuchsia.
3. Updated ifdefs for _strnicmp()/strncasecmd(), so _strnicmp()
   is used on all platforms
3. Updated ifdefs in clock.cc to avoid invalid assumption that
   POSIX = LINUX || MAC .

Bug:  chromium:750940 
Change-Id: Id7aa98e017f467bcebb78a0b298ba91655502072
Reviewed-on: https://webrtc-review.googlesource.com/31641
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21233}
[modify] https://crrev.com/6acefdb70a0b6d86b4f5682f1a28257466efef9c/BUILD.gn
[modify] https://crrev.com/6acefdb70a0b6d86b4f5682f1a28257466efef9c/modules/rtp_rtcp/source/rtp_utility.cc
[modify] https://crrev.com/6acefdb70a0b6d86b4f5682f1a28257466efef9c/modules/video_capture/device_info_impl.cc
[modify] https://crrev.com/6acefdb70a0b6d86b4f5682f1a28257466efef9c/rtc_base/platform_thread.cc
[modify] https://crrev.com/6acefdb70a0b6d86b4f5682f1a28257466efef9c/rtc_base/platform_thread_types.h
[modify] https://crrev.com/6acefdb70a0b6d86b4f5682f1a28257466efef9c/system_wrappers/source/clock.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31ba2a0f82e5d46f50a319ae5a3b8ccd0f60b1bd

commit 31ba2a0f82e5d46f50a319ae5a3b8ccd0f60b1bd
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Dec 14 01:44:33 2017

Roll openmax_dl 7acede9 -> b611996

The new version replaces asm() with __asm__() which allows compilation
with --std=c11

Bug:  750940 
Change-Id: I62e3603b3e969d046cf707fcfde756fa71fe9abc
Reviewed-on: https://chromium-review.googlesource.com/825982
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523977}
[modify] https://crrev.com/31ba2a0f82e5d46f50a319ae5a3b8ccd0f60b1bd/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/792e646b22c5a9bf50d681f75f0421e5b8086c0f

commit 792e646b22c5a9bf50d681f75f0421e5b8086c0f
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Dec 15 02:27:25 2017

Enable WebRTC on Fuchsia by default.

1. Updated BUILD.gn for usrsctp to pass correct build flags
   on Fuchsia.
2. Enabled WebRTC on Fuchsia.
3. Updated 2 unittests for Fuchsia.

Bug:  750940 
Change-Id: I922aa74ca17c542a9b1ca53b60763d8130406f9e
Reviewed-on: https://chromium-review.googlesource.com/817947
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524296}
[modify] https://crrev.com/792e646b22c5a9bf50d681f75f0421e5b8086c0f/build/args/fuchsia.gn
[modify] https://crrev.com/792e646b22c5a9bf50d681f75f0421e5b8086c0f/content/browser/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/792e646b22c5a9bf50d681f75f0421e5b8086c0f/content/renderer/media/webrtc_audio_renderer_unittest.cc
[modify] https://crrev.com/792e646b22c5a9bf50d681f75f0421e5b8086c0f/media/media_options.gni
[modify] https://crrev.com/792e646b22c5a9bf50d681f75f0421e5b8086c0f/third_party/usrsctp/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment