New issue
Advanced search Search tips

Issue 750934 link

Starred by 3 users

Issue metadata

Status: Verified
Owner: ----
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug

Blocking:
issue 746674



Sign in to add a comment

Headless Fuchsia: Port the "moderate complexity" fixes

Project Member Reported by kmarshall@chromium.org, Jul 31 2017

Issue description

This bug tracks the effort for porting the changes detailed in the "moderate difficulty fixes" section of the Headless port findings doc, from the port CL to Chromium head.

Doc: https://docs.google.com/a/chromium.org/document/d/18qh1MRMKs8O5bmHp2nCNg0WJi1YyDs8-cu_Pxq76174/edit?usp=sharing

CL: https://chromium-review.googlesource.com/c/590388/

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f5774954dde50ca7a9e166f18e040c0b64cc639

commit 5f5774954dde50ca7a9e166f18e040c0b64cc639
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Aug 08 02:31:57 2017

Fuchsia: add stub timezone monitor class.

This will be implemented as the porting effort progresses.

Bug:  750934 
Change-Id: I44260df992d0d8455ed9a56a39b8e715518860e1
Reviewed-on: https://chromium-review.googlesource.com/601330
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492509}
[modify] https://crrev.com/5f5774954dde50ca7a9e166f18e040c0b64cc639/services/device/time_zone_monitor/BUILD.gn
[add] https://crrev.com/5f5774954dde50ca7a9e166f18e040c0b64cc639/services/device/time_zone_monitor/time_zone_monitor_fuchsia.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8162cfa731fc9b0b51f67fc5534a5108227d11b

commit b8162cfa731fc9b0b51f67fc5534a5108227d11b
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Aug 09 00:16:57 2017

Set disable-gpu flag for Fuchsia headless shell.

Disabling the GPU process by default forces the headless shell
to use software rendering.


R=skyostil@chromium.org

Bug:  750934 
Change-Id: I34311442422cf0a6061d45a84ac28502b1a7cac7
Reviewed-on: https://chromium-review.googlesource.com/603930
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492785}
[modify] https://crrev.com/b8162cfa731fc9b0b51f67fc5534a5108227d11b/headless/app/headless_shell.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e22361a675c05a9e878be2396e220d97cc3378f

commit 3e22361a675c05a9e878be2396e220d97cc3378f
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 10 05:32:00 2017

Disable desktop capture when WebRTC is disabled.

Desktop Capture exposes internal WebRTC structs that aren't available
when third_party/webrtc is unbuildable (currently the case
under OS_FUCHSIA).


Bug:  750934 
Change-Id: Ied22fac478806300e3e5758293b5fa0845e382fc
Reviewed-on: https://chromium-review.googlesource.com/605067
Reviewed-by: Zijie He <zijiehe@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493277}
[modify] https://crrev.com/3e22361a675c05a9e878be2396e220d97cc3378f/content/public/browser/BUILD.gn

Blocking: 746674
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76b5483eae6dfb4e71c759e84d2f2611b42e2404

commit 76b5483eae6dfb4e71c759e84d2f2611b42e2404
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 10 18:01:52 2017

Fuchsia: explicitly specify lack of system geo providers.

Fuchsia doesn't have a native geo service at this point, so simply
return nullptr as we do for desktop builds.


Bug:  750934 
Change-Id: I0beb2e2b91fedf383c8c450a7cc87b1edef307da
Reviewed-on: https://chromium-review.googlesource.com/609390
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493458}
[modify] https://crrev.com/76b5483eae6dfb4e71c759e84d2f2611b42e2404/device/geolocation/location_arbitrator.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d4d498af0e035ba75d4d25914652ad695627f89

commit 5d4d498af0e035ba75d4d25914652ad695627f89
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 10 19:29:28 2017

Fuchsia: add NOTIMPLEMENTED() stubs for sensor data consumer buffers.

Bug:  750934 , 746674 
Change-Id: Iec302dbf4c4e2ede9144e619083b78f2a5914ceb
Reviewed-on: https://chromium-review.googlesource.com/609041
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493497}
[modify] https://crrev.com/5d4d498af0e035ba75d4d25914652ad695627f89/device/sensors/BUILD.gn
[add] https://crrev.com/5d4d498af0e035ba75d4d25914652ad695627f89/device/sensors/data_fetcher_shared_memory_fuchsia.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbec5c20fdd4075029281891d569f17bb98bdc06

commit bbec5c20fdd4075029281891d569f17bb98bdc06
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Aug 15 01:06:17 2017

Fuchsia: Only use in-memory lock table for LevelDB

Remove file locking/unlocking calls, as they are unsupported
under Fuchsia.


Bug:  750934 
Change-Id: Ia17b1846b2b56248435b559e447f8349c47f1ac6
Reviewed-on: https://chromium-review.googlesource.com/614361
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494281}
[modify] https://crrev.com/bbec5c20fdd4075029281891d569f17bb98bdc06/third_party/leveldatabase/env_chromium.cc
[modify] https://crrev.com/bbec5c20fdd4075029281891d569f17bb98bdc06/third_party/leveldatabase/env_chromium_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcf832720ff7c0d4960b3cdd5571d5a351c0506c

commit dcf832720ff7c0d4960b3cdd5571d5a351c0506c
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Aug 15 01:08:47 2017

Fuchsia: Disable setproctitle/signal handler setup in ServiceManager.

This CL disables UNIX-specific setup calls under Fuchsia, which
is partially POSIX compliant but not actually a UNIX.


Bug:  750934 
Change-Id: Id5b5b6a720030765d05b69e377a5c7ff0062f2f0
Reviewed-on: https://chromium-review.googlesource.com/614180
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494282}
[modify] https://crrev.com/dcf832720ff7c0d4960b3cdd5571d5a351c0506c/services/service_manager/embedder/main.cc
[modify] https://crrev.com/dcf832720ff7c0d4960b3cdd5571d5a351c0506c/services/service_manager/embedder/set_process_title.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee648e82b03b518a5d73897e67d295938374c2d8

commit ee648e82b03b518a5d73897e67d295938374c2d8
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Aug 15 01:27:02 2017

Fuchsia: add a null implementation for MemoryMonitor.

Bug:  750934 
Change-Id: I5e0714f8ee64ba76c5b99abaf9739b990fde7cb9
Reviewed-on: https://chromium-review.googlesource.com/611420
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494290}
[modify] https://crrev.com/ee648e82b03b518a5d73897e67d295938374c2d8/content/browser/BUILD.gn
[add] https://crrev.com/ee648e82b03b518a5d73897e67d295938374c2d8/content/browser/memory/memory_monitor_fuchsia.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b48e6ef55a482c039e797a544a9cccc70f2ed6c

commit 7b48e6ef55a482c039e797a544a9cccc70f2ed6c
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 17 23:46:31 2017

Fuchsia: move jingle_glue to enable_webrtc conditional deps.

Bug:  750934 
Change-Id: I2dd3828ad7036eb196516913530039a9ed228938
Reviewed-on: https://chromium-review.googlesource.com/619807
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495383}
[modify] https://crrev.com/7b48e6ef55a482c039e797a544a9cccc70f2ed6c/content/renderer/BUILD.gn

Status: Verified (was: Untriaged)

Sign in to add a comment