New issue
Advanced search Search tips

Issue 750925 link

Starred by 1 user
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Aug 2017
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Filters incorrectly drawn across tile boundaries

Project Member Reported by pdr@chromium.org, Jul 31 2017 
Chrome Version: Chrome 61.0.3163.13
OS: MacOS

What steps will reproduce the problem?
(1) Open the attached testcase
(2) Zoom in and out with ctrl/cmd and (+/-)
(3) Notice the top-half of the box is not blue

What is the expected result?
Top half of the box should be blue

What happens instead?
Filtered content is not rendered across tile boundaries.
filterbug.html
469 bytes View Download

Comment 1 by pdr@chromium.org, Jul 31 2017

Labels: -Type-Bug M-59 Type-Bug-Regression
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
Regression range:
https://chromium.googlesource.com/chromium/src/+log/a9e7f034a9aa1353d418d8ac3c745a0450763c05..ed71ca7437db67890fdc2848ff4edea9aa2b0cca

I think this is likely:
Account for perspective and preserve-3d in mapToVisualRectInAncestorSpace
https://codereview.chromium.org/2727093002

Comment 2 by schenney@chromium.org, Aug 1 2017

Labels: PaintTeamTriaged-20170801 BugSource-Team
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0fdc9badcd1af3b5bcdced50925bcf031ad6e44

commit c0fdc9badcd1af3b5bcdced50925bcf031ad6e44
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Thu Aug 03 01:50:55 2017

Fix typo leading to double-calls to mapToVisualRectInAncestorSpace.

This was accidentally introduced by https://codereview.chromium.org/2727093002.
It affects only LayoutViews for iframes that end up in the slow path for
paint invalidation, which is only for content under filter or multicolumn.

Bug:  750925 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9a183e0151f584e299134ba3091c440a7d24f0d1
Reviewed-on: https://chromium-review.googlesource.com/599113
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491605}
[modify] https://crrev.com/c0fdc9badcd1af3b5bcdced50925bcf031ad6e44/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
[modify] https://crrev.com/c0fdc9badcd1af3b5bcdced50925bcf031ad6e44/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Comment 4 by chrishtr@chromium.org, Aug 3 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment