Bluetooth tray log span: "Unknown device type icon for Bluetooth was requested" |
||||||
Issue descriptionWhen testing the Bluetooth UI, I see the following text spam the chrome log when I use the system tray: "Unknown device type icon for Bluetooth was requested" It seems to be happening every frame causing significant slowdown when the UI is open. Unfortunately gittles does not show blame beyond the recent file move, but my local blame suggests fukino@ Since it is a LOG(WARNING) making this a P1 as it is spamming user logs in release builds and may be impacting performance when the tray is open.
,
Aug 4 2017
This eventually causes a freeze, and then a system crash resulting in a reboot.
,
Aug 4 2017
,
Aug 4 2017
,
Aug 16 2017
The log is always output when the device is classified to UNKNOWN. (i.e. the device class is known to BluetoothDevice::GetDeviceType() function.) https://codesearch.chromium.org/chromium/src/device/bluetooth/bluetooth_device.cc?sq=package:chromium&l=153 I think we don't have to treat it as warning. Devices in the wild or devices following newer BT spec can advertise unknown device class to our existing classifier. Using general Bluetooth icon for such unknown BT devices should be fine. I'll remove the LOG(WARNING) line.
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd491cc525f2eaf1b0b2a891610ad45e7ef08ff5 commit cd491cc525f2eaf1b0b2a891610ad45e7ef08ff5 Author: Naoki Fukino <fukino@chromium.org> Date: Thu Aug 17 04:47:20 2017 cros: Remove warning log on requesting an icon for unknown BT device type. Devices can advertise a BT device class which is unknown for our classifier. Outputting warning logs for such devices is slowing down the device. We don't have to output warnings since general BT icons for such unknown devices work fine. Bug: 750922 Change-Id: I53678d914780cccd0d3cd3dedfa95de7d8b4ac21 Reviewed-on: https://chromium-review.googlesource.com/616584 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#495075} [modify] https://crrev.com/cd491cc525f2eaf1b0b2a891610ad45e7ef08ff5/ash/system/bluetooth/tray_bluetooth.cc
,
Aug 17 2017
,
Oct 2 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hansberry@chromium.org
, Aug 4 2017