moblab: external-disk-init races with automount |
||||||
Issue descriptionI've noticed this a few times: the external drive can get mounted at /media/.../MOBLAB-STORAGE (probably by cros-disks) then, moblab-external-storage-init chokes when trying to run fsck on it. This causes all other moblab services to not run (and hence setup to fail). Fix would be for moblab-external-storage-init to first unmount the usb_disk.
,
Jul 31 2017
The path where it gets mounted is /media/removalbe/MOBLAB-STORAGE
,
Aug 4 2017
I am working on this file anyway so I will put in a fix.
,
Aug 4 2017
,
Aug 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/6c649639a56b8e78afcda5bf966a91fb27030979 commit 6c649639a56b8e78afcda5bf966a91fb27030979 Author: Keith Haddow <haddowk@chromium.org> Date: Sat Aug 05 01:08:19 2017 [moblab] Change the external mounting script to preserve permissions. Some of the files on the external file need to keep the permissions granted at creation time, reduce the scope of what is chowned to moblab. Fix issue where fsck sometimes failed because the usb had been mounted by another part of chromeos. BUG= chromium:752556 , chromium:750921 TEST=local moblab testing Change-Id: If03fb27fe744ecd9e694c5b7124655684958ca14 Reviewed-on: https://chromium-review.googlesource.com/602614 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> [modify] https://crrev.com/6c649639a56b8e78afcda5bf966a91fb27030979/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf [rename] https://crrev.com/6c649639a56b8e78afcda5bf966a91fb27030979/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r62.ebuild
,
Aug 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/11b1e6a73ab02e0e1d27bf794fcf7a445d74f3a4 commit 11b1e6a73ab02e0e1d27bf794fcf7a445d74f3a4 Author: Keith Haddow <haddowk@chromium.org> Date: Sat Aug 05 17:07:12 2017 [moblab] Change the external mounting script to preserve permissions. Some of the files on the external file need to keep the permissions granted at creation time, reduce the scope of what is chowned to moblab. Fix issue where fsck sometimes failed because the usb had been mounted by another part of chromeos. BUG= chromium:752556 , chromium:750921 TEST=local moblab testing Change-Id: If03fb27fe744ecd9e694c5b7124655684958ca14 Reviewed-on: https://chromium-review.googlesource.com/602614 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> (cherry picked from commit 6c649639a56b8e78afcda5bf966a91fb27030979) Reviewed-on: https://chromium-review.googlesource.com/602886 Commit-Queue: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/11b1e6a73ab02e0e1d27bf794fcf7a445d74f3a4/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf [add] https://crrev.com/11b1e6a73ab02e0e1d27bf794fcf7a445d74f3a4/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r62.ebuild
,
Aug 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/28531e86cfe131131dd3c7072837fbf7ddd54b0d commit 28531e86cfe131131dd3c7072837fbf7ddd54b0d Author: Keith Haddow <haddowk@chromium.org> Date: Sat Aug 05 17:07:16 2017 [moblab] Change the external mounting script to preserve permissions. Some of the files on the external file need to keep the permissions granted at creation time, reduce the scope of what is chowned to moblab. Fix issue where fsck sometimes failed because the usb had been mounted by another part of chromeos. BUG= chromium:752556 , chromium:750921 TEST=local moblab testing Change-Id: If03fb27fe744ecd9e694c5b7124655684958ca14 Reviewed-on: https://chromium-review.googlesource.com/602614 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> (cherry picked from commit 6c649639a56b8e78afcda5bf966a91fb27030979) Reviewed-on: https://chromium-review.googlesource.com/602885 Commit-Queue: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/28531e86cfe131131dd3c7072837fbf7ddd54b0d/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf [add] https://crrev.com/28531e86cfe131131dd3c7072837fbf7ddd54b0d/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r62.ebuild
,
Aug 8 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by pprabhu@chromium.org
, Jul 31 2017