New issue
Advanced search Search tips

Issue 750917 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Task

Blocking:
issue 746674



Sign in to add a comment

Headless Fuchsia: Port the "simple" fixes

Project Member Reported by kmarshall@chromium.org, Jul 31 2017

Issue description

This bug tracks the effort for porting the changes detailed in the "simple fixes" section of the Headless port findings doc, from the port CL to Chromium head.

Doc: https://docs.google.com/a/chromium.org/document/d/18qh1MRMKs8O5bmHp2nCNg0WJi1YyDs8-cu_Pxq76174/edit?usp=sharing

CL: https://chromium-review.googlesource.com/c/590388/
 

Comment 1 by w...@chromium.org, Jul 31 2017

Components: Internals>Headless
Labels: M-62
Summary: Headless Fuchsia: Port the "simple" fixes (was: Port simple fixes for Fuchsia headless port CL)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bc690a0c3b11278b9b41f3b3e4805521647e89b

commit 5bc690a0c3b11278b9b41f3b3e4805521647e89b
Author: Wez <wez@chromium.org>
Date: Wed Aug 02 22:11:12 2017

Add Fuchsia to the available Study::Platform enum values.

BUG= 750917 

Change-Id: Ia6a2f446a6ae8ec0228c12f587756561df0e6051
Reviewed-on: https://chromium-review.googlesource.com/597376
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491525}
[modify] https://crrev.com/5bc690a0c3b11278b9b41f3b3e4805521647e89b/components/variations/client_filterable_state.cc
[modify] https://crrev.com/5bc690a0c3b11278b9b41f3b3e4805521647e89b/components/variations/proto/study.proto
[modify] https://crrev.com/5bc690a0c3b11278b9b41f3b3e4805521647e89b/components/variations/study_filtering_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e0bd52f773b7e06fa9237154110d9963d5aea03

commit 0e0bd52f773b7e06fa9237154110d9963d5aea03
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Aug 08 04:27:16 2017

Modify GN feature args for Fuchsia.

Turn off some features when is_fuchsia=true. The features may be
re-added in the future as progress continues on the Chromium port
and the OS itself.

It's necessary for bringing headless_shell to a buildable state.


R: scottmg@chromium.org,thakis@chromium.org
Bug:  750917 
Change-Id: I7011dfa559474d7eacce9482ae02c3330d113e94
Reviewed-on: https://chromium-review.googlesource.com/596621
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492531}
[modify] https://crrev.com/0e0bd52f773b7e06fa9237154110d9963d5aea03/build/args/headless.gn
[modify] https://crrev.com/0e0bd52f773b7e06fa9237154110d9963d5aea03/build/config/ui.gni
[modify] https://crrev.com/0e0bd52f773b7e06fa9237154110d9963d5aea03/headless/BUILD.gn
[modify] https://crrev.com/0e0bd52f773b7e06fa9237154110d9963d5aea03/media/media_options.gni
[modify] https://crrev.com/0e0bd52f773b7e06fa9237154110d9963d5aea03/ppapi/features/features.gni
[modify] https://crrev.com/0e0bd52f773b7e06fa9237154110d9963d5aea03/printing/features/features.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f423b4deb515f78c7868ec4b39c091cd28b669dd

commit f423b4deb515f78c7868ec4b39c091cd28b669dd
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Aug 08 17:40:53 2017

Revert "Modify GN feature args for Fuchsia."

This reverts commit 0e0bd52f773b7e06fa9237154110d9963d5aea03.

Reason for revert: The dragdrop data provider needs to be upstreamed from port CL before this will build.

Original change's description:
> Modify GN feature args for Fuchsia.
> 
> Turn off some features when is_fuchsia=true. The features may be
> re-added in the future as progress continues on the Chromium port
> and the OS itself.
> 
> It's necessary for bringing headless_shell to a buildable state.
> 
> 
> R: scottmg@chromium.org,thakis@chromium.org
> Bug:  750917 
> Change-Id: I7011dfa559474d7eacce9482ae02c3330d113e94
> Reviewed-on: https://chromium-review.googlesource.com/596621
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492531}

TBR=bbudge@chromium.org,dalecurtis@chromium.org,thakis@chromium.org,thestig@chromium.org,kmarshall@chromium.org,skyostil@chromium.org,scottmg@chromium.org,altimin@chromium.org

Change-Id: I0c7ac7b55bf18127cc2ad52c90b1b9f301900def
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  750917 
Reviewed-on: https://chromium-review.googlesource.com/606747
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492689}
[modify] https://crrev.com/f423b4deb515f78c7868ec4b39c091cd28b669dd/build/args/headless.gn
[modify] https://crrev.com/f423b4deb515f78c7868ec4b39c091cd28b669dd/build/config/ui.gni
[modify] https://crrev.com/f423b4deb515f78c7868ec4b39c091cd28b669dd/headless/BUILD.gn
[modify] https://crrev.com/f423b4deb515f78c7868ec4b39c091cd28b669dd/media/media_options.gni
[modify] https://crrev.com/f423b4deb515f78c7868ec4b39c091cd28b669dd/ppapi/features/features.gni
[modify] https://crrev.com/f423b4deb515f78c7868ec4b39c091cd28b669dd/printing/features/features.gni

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26cce66983b02f71821793f13f03fd2a9494f836

commit 26cce66983b02f71821793f13f03fd2a9494f836
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Aug 08 19:50:53 2017

Re-use Linux includes for libxslt in Fuchsia

Fuchsia is partially POSIX compliant, so the Linux/POSIX configs
are a reasonable match for Fuchsia.

A Fuchsia-specific configuration can be developed in the future if
incompatibilities are discovered.

Bug:  750917 
Change-Id: Ic5483657297b0cc264ce3c440d99eb4686fee42d
Reviewed-on: https://chromium-review.googlesource.com/604809
Reviewed-by: Dominic Cooney <dominicc@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492733}
[modify] https://crrev.com/26cce66983b02f71821793f13f03fd2a9494f836/third_party/libxslt/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b73a98f7607d9bc36ad72ba4e4dc54c942402c7d

commit b73a98f7607d9bc36ad72ba4e4dc54c942402c7d
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 10 05:39:04 2017

Fuchsia: fix the format string placeholder for PID type.

Fuchsia's PIDs are unsigned longs, which are incompatible with the
default "%d" used by CrPRIpPid.


Bug:  750917 
Change-Id: Ib254b9b351f65f860f0ff433d2d30b5a036669e4
Reviewed-on: https://chromium-review.googlesource.com/606552
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493289}
[modify] https://crrev.com/b73a98f7607d9bc36ad72ba4e4dc54c942402c7d/base/process/process_handle.h

Blocking: 746674
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c92e33bb86be867d4d43abd929cb6a3f93393481

commit c92e33bb86be867d4d43abd929cb6a3f93393481
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Aug 15 18:47:18 2017

Fuchsia: disable PPAPI plugins via GN arg.


Bug:  750917 
Change-Id: I4a7581511eaa1452b34b1b2fc743a66d213dc3de
Reviewed-on: https://chromium-review.googlesource.com/615063
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494467}
[modify] https://crrev.com/c92e33bb86be867d4d43abd929cb6a3f93393481/ppapi/features/features.gni

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecd7c6f7c481b506401f889997c3e52a56fd2ac6

commit ecd7c6f7c481b506401f889997c3e52a56fd2ac6
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Aug 15 19:20:24 2017

Fuchsia: disable printing and related GN args.

Bug:  750917 
Change-Id: Ieb4bf45b4f442067a88c8a710869f598b4cb007e
Reviewed-on: https://chromium-review.googlesource.com/615064
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494487}
[modify] https://crrev.com/ecd7c6f7c481b506401f889997c3e52a56fd2ac6/printing/features/features.gni

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1bf4e5dbd013dc98047c148a371d831e11544a4

commit f1bf4e5dbd013dc98047c148a371d831e11544a4
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Aug 15 19:37:58 2017

Fuchsia: Add value for default OS storage accommodation.


Bug:  750917 
Change-Id: Ie3eb61167abefcb65ad1743ec58df5c25307c65b
Reviewed-on: https://chromium-review.googlesource.com/614921
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494500}
[modify] https://crrev.com/f1bf4e5dbd013dc98047c148a371d831e11544a4/storage/browser/quota/quota_settings.cc

Comment 11 by w...@chromium.org, Dec 8 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment