New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 750907 link

Starred by 1 user
Status: Archived
Owner:
█ pho...@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
█ dshi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add argument to chromite.lib.metrics.Secondstimer() to allow not recording on exception

Project Member Reported by pho...@chromium.org, Jul 31 2017 
We may only care about the time an action takes when it succeeds.

Comment 1 by akes...@chromium.org, Aug 8 2017 

^ sometimes we care about how long something takes to fail.

But yes, I can imagine uses for your case too.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9333ce63aab0a66ee7f578153b4b26e85a8f55ba

commit 9333ce63aab0a66ee7f578153b4b26e85a8f55ba
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Aug 17 08:56:57 2017

metrics: Add "record_on_exception" flag to MetricsTimer

Sometimes it doesn't make sense to record how long something took if it
encountered an exception.

BUG= chromium:750907 
TEST=tests pass

Change-Id: I911a092e448d179bb7f05102357ea894c6532625
Reviewed-on: https://chromium-review.googlesource.com/595133
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/9333ce63aab0a66ee7f578153b4b26e85a8f55ba/lib/metrics.py

Comment 3 by pho...@chromium.org, Aug 23 2017

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment