After bug 748879 is implemented to manage and sync EasyUnlock prefs to local state, we need to control the login flow using the pref rather than a flag.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24eff336a68df066f824cd3714ab43fb47e7ece7 commit 24eff336a68df066f824cd3714ab43fb47e7ece7 Author: Tim Song <tengs@chromium.org> Date: Thu Aug 10 23:12:13 2017 [EasyUnlock] Control login flow based on is_chromeos_login_enabled pref. The login flow was previously controlled by a flag, which this CL removes. Now, the EasyUnlock login flow can be enabled or disabled through chrome://settings. This CL also does some much needed refactoring in EasyUnlockServiceSignIn in order to clean up some UI glitches when EasyUnlock is not enabled or allowed. BUG= 750893 Change-Id: I4398e185a67ea1554756970a13dc1d2194567e8d Reviewed-on: https://chromium-review.googlesource.com/601216 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#493589} [modify] https://crrev.com/24eff336a68df066f824cd3714ab43fb47e7ece7/chrome/browser/signin/easy_unlock_screenlock_state_handler.cc [modify] https://crrev.com/24eff336a68df066f824cd3714ab43fb47e7ece7/chrome/browser/signin/easy_unlock_screenlock_state_handler.h [modify] https://crrev.com/24eff336a68df066f824cd3714ab43fb47e7ece7/chrome/browser/signin/easy_unlock_service.cc [modify] https://crrev.com/24eff336a68df066f824cd3714ab43fb47e7ece7/chrome/browser/signin/easy_unlock_service.h [modify] https://crrev.com/24eff336a68df066f824cd3714ab43fb47e7ece7/chrome/browser/signin/easy_unlock_service_regular.cc [modify] https://crrev.com/24eff336a68df066f824cd3714ab43fb47e7ece7/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/24eff336a68df066f824cd3714ab43fb47e7ece7/chrome/browser/signin/easy_unlock_service_signin_chromeos.h [modify] https://crrev.com/24eff336a68df066f824cd3714ab43fb47e7ece7/components/proximity_auth/screenlock_state.h [modify] https://crrev.com/24eff336a68df066f824cd3714ab43fb47e7ece7/components/proximity_auth/switches.cc [modify] https://crrev.com/24eff336a68df066f824cd3714ab43fb47e7ece7/components/proximity_auth/switches.h
Approving merge to M61 Chrome OS.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f021bd28f194db450bfa22d2e90d08bd026077e5 commit f021bd28f194db450bfa22d2e90d08bd026077e5 Author: Tim Song <tengs@chromium.org> Date: Thu Aug 10 23:32:03 2017 [EasyUnlock] Control login flow based on is_chromeos_login_enabled pref. The login flow was previously controlled by a flag, which this CL removes. Now, the EasyUnlock login flow can be enabled or disabled through chrome://settings. This CL also does some much needed refactoring in EasyUnlockServiceSignIn in order to clean up some UI glitches when EasyUnlock is not enabled or allowed. BUG= 750893 TBR=tengs@chromium.org (cherry picked from commit 24eff336a68df066f824cd3714ab43fb47e7ece7) Change-Id: I4398e185a67ea1554756970a13dc1d2194567e8d Reviewed-on: https://chromium-review.googlesource.com/601216 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493589} Reviewed-on: https://chromium-review.googlesource.com/611309 Reviewed-by: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#473} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/f021bd28f194db450bfa22d2e90d08bd026077e5/chrome/browser/signin/easy_unlock_screenlock_state_handler.cc [modify] https://crrev.com/f021bd28f194db450bfa22d2e90d08bd026077e5/chrome/browser/signin/easy_unlock_screenlock_state_handler.h [modify] https://crrev.com/f021bd28f194db450bfa22d2e90d08bd026077e5/chrome/browser/signin/easy_unlock_service.cc [modify] https://crrev.com/f021bd28f194db450bfa22d2e90d08bd026077e5/chrome/browser/signin/easy_unlock_service.h [modify] https://crrev.com/f021bd28f194db450bfa22d2e90d08bd026077e5/chrome/browser/signin/easy_unlock_service_regular.cc [modify] https://crrev.com/f021bd28f194db450bfa22d2e90d08bd026077e5/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/f021bd28f194db450bfa22d2e90d08bd026077e5/chrome/browser/signin/easy_unlock_service_signin_chromeos.h [modify] https://crrev.com/f021bd28f194db450bfa22d2e90d08bd026077e5/components/proximity_auth/screenlock_state.h [modify] https://crrev.com/f021bd28f194db450bfa22d2e90d08bd026077e5/components/proximity_auth/switches.cc [modify] https://crrev.com/f021bd28f194db450bfa22d2e90d08bd026077e5/components/proximity_auth/switches.h
Comment 1 by bugdroid1@chromium.org
, Aug 10 2017