New issue
Advanced search Search tips

Issue 750882 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Add support for signaling which sensor changed at PlatformSensor::Client

Project Member Reported by juncai@chromium.org, Jul 31 2017

Issue description

As per comments on https://chromium-review.googlesource.com/c/578253/, it would be better to know which sensor had a reading change, since fusion sensor algorithms may update different parts of their internal state depending on which sensor has changed.
 
Components: Blink>Sensor
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/366f55322b5f2cef79f1c0d38d269576da6c02bc

commit 366f55322b5f2cef79f1c0d38d269576da6c02bc
Author: Jun Cai <juncai@chromium.org>
Date: Wed Aug 02 01:51:54 2017

Add support for signaling which sensor changed at PlatformSensor::Client

This CL adds a "mojom::SensorType type" parameter to the
PlatformSensor::Client::OnSensorReadingChanged() function to signal
which sensor has changed its data. By doing this, fusion sensor
algorithms may update different parts of their internal state depending
on which sensor has changed.

Bug:  750882 
Change-Id: I26fad3e80c4a63337fd89d58ba6a62a6c1d5880a
Reviewed-on: https://chromium-review.googlesource.com/594720
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491198}
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/linear_acceleration_fusion_algorithm_using_accelerometer.cc
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/linear_acceleration_fusion_algorithm_using_accelerometer.h
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/orientation_quaternion_fusion_algorithm_using_euler_angles.cc
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/orientation_quaternion_fusion_algorithm_using_euler_angles.h
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/platform_sensor.cc
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/platform_sensor.h
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/platform_sensor_fusion.cc
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/platform_sensor_fusion.h
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/platform_sensor_fusion_algorithm.h
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/relative_orientation_euler_angles_fusion_algorithm_using_accelerometer.cc
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/relative_orientation_euler_angles_fusion_algorithm_using_accelerometer.h
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/sensor_impl.cc
[modify] https://crrev.com/366f55322b5f2cef79f1c0d38d269576da6c02bc/services/device/generic_sensor/sensor_impl.h

Status: Fixed (was: Started)

Sign in to add a comment