New issue
Advanced search Search tips

Issue 750880 link

Starred by 1 user
Status: Fixed
Owner:
chengx@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Flaky DCHECK in JumpList::ProcessNotifications during context_lost_tests on Win NVIDIA

Project Member Reported by ynovikov@chromium.org, Jul 31 2017 
Started in https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28NVIDIA%20Quadro%20P400%29/builds/1271

In GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash test there is:

[7760:8400:0728/041933.583:FATAL:jumplist.cc(341)] Check failed: !update_in_progress_. 
Backtrace:
	base::debug::StackTrace::StackTrace [0x71841FE7+55]
	base::debug::StackTrace::StackTrace [0x718248FA+10]
	JumpList::ProcessNotifications [0x7282D3C2+157]
	base::Timer::RunScheduledTask [0x71801BE5+181]
	base::debug::TaskAnnotator::RunTask [0x7185B8DE+398]
	base::MessageLoop::RunTask [0x7180512E+1374]
	base::MessageLoop::DeferOrRunPendingTask [0x71803F98+72]
	base::MessageLoop::DoDelayedWork [0x71804318+216]
	base::MessagePumpForUI::DoRunLoop [0x7185D2C5+117]
	base::MessagePumpWin::Run [0x7185DA3A+74]
	base::MessageLoop::Run [0x71804BBB+107]
	base::RunLoop::Run [0x7181E9EC+156]
	ChromeBrowserMainParts::MainMessageLoopRun [0x71762B62+235]
	content::BrowserMainLoop::RunMainMessageLoopParts [0x71216FB9+80]
	content::BrowserMain [0x71213A40+130]
	content::RunNamedProcessTypeMain [0x716D1B5C+176]
	content::ContentMainRunnerImpl::Run [0x716D1A7B+280]
	service_manager::Main [0x716E92EA+558]
	content::ContentMain [0x716D1302+39]
	ChromeMain [0x70F0BBA1+200]
	MainDllLoader::Launch [0x00A462F4+445]
	wWinMain [0x00A44111+499]
	__scrt_common_main_seh [0x00D2C928+246] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x74A18744+36]
	RtlGetAppContainerNamedObjectPath [0x77B3587D+253]
	RtlGetAppContainerNamedObjectPath [0x77B3584D+205]

I suspect it started after https://chromium-review.googlesource.com/c/585029/.
chengx@, PTAL.

Comment 1 by chengx@chromium.org, Jul 31 2017 

I'll take a look.

Comment 2 by ynovikov@chromium.org, Jul 31 2017

Summary: Flaky DCHECK in JumpList::ProcessNotifications during context_lost_tests on Win NVIDIA (was: Flaky DCHECK in JumpList::ProcessNotifications during context_lost_tests on Win10 Release (NVIDIA Quadro P400) GPU.FYI bot)
Not specific to Quadro P400 and causes ANGLE CQ flakiness. 
https://uberchromegw.corp.google.com/i/tryserver.chromium.angle/builders/win_angle_rel_ng/builds/5994

Comment 3 by chengx@chromium.org, Aug 1 2017 

I'm landing a CL which removes the related DCHECKs.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/791bed526a0deaa6f0d02cd7512023f3d44489ba

commit 791bed526a0deaa6f0d02cd7512023f3d44489ba
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Aug 01 04:57:18 2017

Remove DCHECK of update_in_progress_ in jumplist

The DCHECK is somehow flaky as mentioned in the attached bug. It's removed
for now as it doesn't affect much of the JumpList functionality. This allows
the investigation of the causes without blocking any releases. 

Bug:  750880 
Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: Id1a064e89886cd31f2619f232cd3f4657f3f3961
Reviewed-on: https://chromium-review.googlesource.com/595008
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490851}
[modify] https://crrev.com/791bed526a0deaa6f0d02cd7512023f3d44489ba/chrome/browser/win/jumplist.cc

Comment 5 by chengx@chromium.org, Aug 2 2017 

Hi ynovikov@, this should be fixed. Please verify and close this bug if it looks good. Thanks!

Comment 6 by ynovikov@chromium.org, Aug 2 2017

Status: Fixed (was: Assigned)
Since it was flaky, I can't really verify it.
Let's mark as Fixed, and I'll reopen if the problem reoccurs.

Comment 7 by ynovikov@chromium.org, Aug 2 2017 

Thanks for fixing!
►

Sign in to add a comment