Chrome crash after return to "Exit prompt" from DOFF |
||||||
Issue descriptionWhat steps will reproduce the problem? (1) go to badssl.com (2) click the security chip in url bar (3) click "exit vr" button when exit prompt showing up (4) click back button when DOFF showing up (5) click "OK" button in the exit prompt UI What is the expected result? Continue in VR What happens instead? Chrome crash due to an assertion failure at this line: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java?rcl=fd6a90946d898d4b0a2caee68fbcd99bd89aca86&l=1342 assert mOnExitVrRequestListener != null;
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4095dae91d0c1ca6a17b6eac81de5de72c14895 commit c4095dae91d0c1ca6a17b6eac81de5de72c14895 Author: Biao She <bshe@chromium.org> Date: Fri Aug 04 18:15:43 2017 Fix Chrome crash after return from DOFF to exit prompt Bug: 750874 Change-Id: I20af0faf8b3acd37989e8d559ca5d688ecc10ca1 Reviewed-on: https://chromium-review.googlesource.com/595075 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#492071} [modify] https://crrev.com/c4095dae91d0c1ca6a17b6eac81de5de72c14895/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Aug 8 2017
,
Aug 8 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9 2017
Merge approved for M61 branch 3163.
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5558cdf8b07d4aa0d4e8791eb038883c12243f9 commit b5558cdf8b07d4aa0d4e8791eb038883c12243f9 Author: Biao She <bshe@chromium.org> Date: Wed Aug 09 21:21:24 2017 Fix Chrome crash after return from DOFF to exit prompt TBR=bshe@chromium.org (cherry picked from commit c4095dae91d0c1ca6a17b6eac81de5de72c14895) Bug: 750874 Change-Id: I20af0faf8b3acd37989e8d559ca5d688ecc10ca1 Reviewed-on: https://chromium-review.googlesource.com/595075 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#492071} Reviewed-on: https://chromium-review.googlesource.com/608848 Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#410} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/b5558cdf8b07d4aa0d4e8791eb038883c12243f9/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Aug 10 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bshe@chromium.org
, Jul 31 2017