New issue
Advanced search Search tips

Issue 750867 link

Starred by 1 user
Status: Assigned
Owner:
tommycli@chromium.org
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebUI: AllowJavascript is overused / abused.

Project Member Reported by tommycli@chromium.org, Jul 31 2017 
AllowJavascript is overused in many places. There should only be one or two instances within a handler.

Many C++ callbacks used as replies to an asynchronous operation or posted task use this right before calling ResolveJavascriptCallback, which is especially egregious.

This is my fault as we never provided good enough guidance for developers.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa14880e020c72fad191ea95846296b2e320346a

commit aa14880e020c72fad191ea95846296b2e320346a
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed Aug 02 16:40:55 2017

WebUI: Provide more explicit guidance on AllowJavascript.

Bug: 750867
Change-Id: I5d2a8093123ba7cd60010f5597c5fbaf3a193188
Reviewed-on: https://chromium-review.googlesource.com/594937
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491401}
[modify] https://crrev.com/aa14880e020c72fad191ea95846296b2e320346a/content/public/browser/web_ui_message_handler.h

Comment 2 by dpa...@chromium.org, May 18 2018

Components: UI>Browser>WebUI

Comment 3 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
►

Sign in to add a comment