Issue metadata
Sign in to add a comment
|
Consider using amended commit messages as new gerrit change description |
||||||||||||||||||||||||
Issue descriptionCL: https://chromium-review.googlesource.com/c/580314 Expected behavior: After submitting a new patch set, the changes on the commit message should be reflected on both the patch summary and the commit message file. Actual behavior: After submitting a new patch set, the changes on the commit message were neither showed up in the patch set summary nor the commit message file.
,
Jul 31 2017
Once you've created a code review with git cl upload, you have to use either git cl description or the web UI to modify the commit message. If you only use git commit --amend, your local commit message edit will be ignored.
,
Jul 31 2017
Re #2, Although this is the current workflow, but this seems to be a worthy one to fix, so that extra step is not needed just to update the commit message.
,
Jul 31 2017
,
Jul 31 2017
,
Jul 31 2017
,
Jul 31 2017
,
Aug 25 2017
,
Aug 28 2017
Yes, we recognize that this behavior is confusing to people who are used to Gerrit. It is, however, the same behavior as Rietveld has always had. We would like to consider changing this, but it will have to be carefully considered.
,
Jan 3 2018
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
,
Jan 5 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mcchou@chromium.org
, Jul 31 2017Labels: Priority-1
Owner: logan@google.com