New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750842 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Extensions: remove registerTests() from cr_extensions_browsertest.js

Project Member Reported by scottchen@chromium.org, Jul 31 2017

Issue description

Owner: scottchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91f960194c913f25ebee2a6521652b9c02c865ea

commit 91f960194c913f25ebee2a6521652b9c02c865ea
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Aug 03 21:20:03 2017

MD Extension: Refactor browser tests.

- Removes unnecessary registerTests()
- Breaks down CrExtensionBrowserTest to smaller sub-classes so test files are included as needed, instead of loading all test files in each TEST_F. (This reduced the generated .cc file from 25XX lines to 16XX lines).
- Allow (in the future) each sub-classes to specify a more specific browserPreload url instead of always loading the entire page.

Bug:  750842 
Change-Id: I9e178728724f41c63e59b4edc81589b4366c9df9
Reviewed-on: https://chromium-review.googlesource.com/595188
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491847}
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_code_section_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_detail_view_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_error_page_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_item_list_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_item_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_keyboard_shortcuts_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_load_error_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_manager_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_navigation_helper_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_options_dialog_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_pack_dialog_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_service_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_shortcut_input_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_sidebar_test.js
[modify] https://crrev.com/91f960194c913f25ebee2a6521652b9c02c865ea/chrome/test/data/webui/extensions/extension_toolbar_test.js

Status: Fixed (was: Started)

Comment 4 by dpa...@chromium.org, Mar 12 2018

Components: UI>Browser>ExtensionsManagement

Sign in to add a comment