New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750834 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
M61
M62



Sign in to add a comment

huddly-updater process does not exit upon an abrupt stop during upgrade

Project Member Reported by porce@chromium.org, Jul 31 2017

Issue description

Any version after M60.

[Symptom]
When a camera is unplugged from the ChromeBox during the bootloader upgrade, the huddly-updater process still continues to live without exiting after time-out.

[Expectation]
The huddly-updater should treat timeout as update failure, and the process should exit with appropriate log messages.

[Analysis]
While the timer logic is already implemented around the access to the libusb, it appears it is not working. 



 
Cc: rpattumani@chromium.org dsunk...@chromium.org
Labels: Proj-Bluestreak
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/huddly-updater/+/d1657dda42865b76537fad2c5068563f437151c5

commit d1657dda42865b76537fad2c5068563f437151c5
Author: Jiwoong Lee <porce@google.com>
Date: Fri Aug 25 03:41:13 2017

Bail out the huddly-updater upon losing the device in the middle of the update.

The situation may occur when the USB cable gets unplugged or
the USB power supply is low.

BUG= chromium:750834 
TEST=Build guado package. Run on DUT. Shut the USB port down in the middle of the firmware upgrade, during buffer allocation, image uploading, image committing respectively.

Change-Id: I00dd6cabeb936ecda7de2c750844ab702305a837
Reviewed-on: https://chromium-review.googlesource.com/633845
Commit-Ready: Jiwoong Lee <porce@chromium.org>
Tested-by: Jiwoong Lee <porce@chromium.org>
Reviewed-by: Zhongze Hu <frankhu@google.com>

[modify] https://crrev.com/d1657dda42865b76537fad2c5068563f437151c5/src/main.cc
[modify] https://crrev.com/d1657dda42865b76537fad2c5068563f437151c5/src/flasher.cc
[modify] https://crrev.com/d1657dda42865b76537fad2c5068563f437151c5/src/minicam_device.cc

Comment 3 by porce@chromium.org, Aug 25 2017

Status: Fixed (was: Untriaged)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment