New issue
Advanced search Search tips

Issue 750829 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

“Assuming Darwin 17 is Mac OS X 10.13” logged on macOS 10.13

Project Member Reported by mark@chromium.org, Jul 31 2017

Issue description

One of these is logged per process startup on the High Sierra (macOS 10.13) beta:

[mmdd/hhmmss.µµµµµµ:WARNING:mac_util.mm(421)] Assuming Darwin 17 is Mac OS X 10.13”

There’s no reason to assume. We now know this to be true.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71dc469a654540b64cc6ca14b59766f41cf715d2

commit 71dc469a654540b64cc6ca14b59766f41cf715d2
Author: Mark Mentovai <mark@chromium.org>
Date: Fri Aug 04 20:07:55 2017

mac: Don't just assume Darwin 17 is macOS 10.13, confidently know it

As tested on 10.13db4 17A315i:

litterbox@litterbox zsh% uname -r
17.0.0
litterbox@litterbox zsh% sw_vers -productVersion
10.13

This prevents pretty much every Chrome process from DLOGging:

...:WARNING:mac_util.mm(421)] Assuming Darwin 17 is Mac OS X 10.13

Bug:  750829 
Change-Id: I374117d8ba87ba57d9ff05436710e92722026a2f
Reviewed-on: https://chromium-review.googlesource.com/594871
Reviewed-by: Jayson Adams <shrike@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492111}
[modify] https://crrev.com/71dc469a654540b64cc6ca14b59766f41cf715d2/base/mac/mac_util.mm

Comment 3 Deleted

Comment 4 Deleted

Comment 5 by mark@chromium.org, Aug 8 2017

Status: Fixed (was: Started)

Sign in to add a comment