Support hardware video decode with the passthrough command decoder. |
|||
Issue descriptionGpuVideoDecodeAccelerator::OnAssignPictureBuffers uses the TextureManager object from the validating command decoder to update the size and type of the textures that are being used as the destination of video decode. It generates errors if the textures do not exist. This tracking isn't necessary for the passthrough command decoder. Update GpuVideoDecodeAccelerator to function without the availability of TextureRef objects while still doing enough validation.
,
Aug 3 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/20963ff2867fd6f0e2982bdfba26707a33349601 commit 20963ff2867fd6f0e2982bdfba26707a33349601 Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Thu Aug 03 00:23:26 2017 Roll skia/third_party/externals/angle2/ 6c58b0620..a0bcc50be (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/6c58b06200ef..a0bcc50be0c7 $ git log 6c58b0620..a0bcc50be --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep skia/third_party/externals/angle2 BUG= 750813 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE TBR=liyuqian@google.com Change-Id: I9bde78530dfcbed956642d0f1d86cc0b684101ce Reviewed-on: https://skia-review.googlesource.com/30243 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> [modify] https://crrev.com/20963ff2867fd6f0e2982bdfba26707a33349601/DEPS
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/912131cf4d8db3bb52f3364ed1f276ef0c606ffb commit 912131cf4d8db3bb52f3364ed1f276ef0c606ffb Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Thu Aug 03 03:35:08 2017 Roll src/third_party/skia/ f12d84275..255607f09 (2 commits) https://skia.googlesource.com/skia.git/+log/f12d84275cfa..255607f094da $ git log f12d84275..255607f09 --date=short --no-merges --format='%ad %ae %s' 2017-08-02 mtklein 8-bit hacking 2017-08-02 skia-deps-roller Roll skia/third_party/externals/angle2/ 6c58b0620..a0bcc50be (2 commits) Created with: roll-dep src/third_party/skia BUG= 750813 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I93ac33e9029b8ae6540dc545d28b4d53c986890b Reviewed-on: https://chromium-review.googlesource.com/598511 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491634} [modify] https://crrev.com/912131cf4d8db3bb52f3364ed1f276ef0c606ffb/DEPS
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/229c603a647d42f4754e6517e4376cf7f3805908 commit 229c603a647d42f4754e6517e4376cf7f3805908 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Aug 03 14:33:16 2017 Roll ANGLE 5788d24..a0bcc50 https://chromium.googlesource.com/angle/angle.git/+log/5788d24..a0bcc50 BUG= 750813 TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I54127f2ed6fa648e85a104a925fd3a6affaf5407 Reviewed-on: https://chromium-review.googlesource.com/598942 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#491734} [modify] https://crrev.com/229c603a647d42f4754e6517e4376cf7f3805908/DEPS
,
Aug 10 2017
NOTE: Still need to support the BindImage function in gpu_video_decode_accelerator.cc
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/238d7b65fc8c660907eb560df9b9888584c2847c commit 238d7b65fc8c660907eb560df9b9888584c2847c Author: Geoff Lang <geofflang@chromium.org> Date: Fri Aug 11 16:16:52 2017 Don't require TextureRef objects for hardware video decode. BUG= 750813 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic90890549b59010539a62a10e83c4bc1ef8adc8a Reviewed-on: https://chromium-review.googlesource.com/594832 Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: John Bauman <jbauman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#493769} [modify] https://crrev.com/238d7b65fc8c660907eb560df9b9888584c2847c/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
,
Aug 17 2017
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f30a9cc3156020851e90e6169293dd03aeed56ba commit f30a9cc3156020851e90e6169293dd03aeed56ba Author: Geoff Lang <geofflang@chromium.org> Date: Wed Aug 23 18:55:09 2017 Implement GPU video decode BindImage for the passthrough cmd decoder. Both decoders now have the same behaviour when binding textures including maintaining the GLImage references. TEST=Windows WebGL video tests on Intel bots BUG= 750813 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6fa23cca69ecd4c4e1fed2b6624a93c4122c88a4 Reviewed-on: https://chromium-review.googlesource.com/619273 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#496754} [modify] https://crrev.com/f30a9cc3156020851e90e6169293dd03aeed56ba/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/f30a9cc3156020851e90e6169293dd03aeed56ba/gpu/command_buffer/service/gles2_cmd_decoder.h [modify] https://crrev.com/f30a9cc3156020851e90e6169293dd03aeed56ba/gpu/command_buffer/service/gles2_cmd_decoder_mock.h [modify] https://crrev.com/f30a9cc3156020851e90e6169293dd03aeed56ba/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc [modify] https://crrev.com/f30a9cc3156020851e90e6169293dd03aeed56ba/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h [modify] https://crrev.com/f30a9cc3156020851e90e6169293dd03aeed56ba/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc [modify] https://crrev.com/f30a9cc3156020851e90e6169293dd03aeed56ba/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f414b1e5f6ac3f555f6bcaef077937ca372a7d48 commit f414b1e5f6ac3f555f6bcaef077937ca372a7d48 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Aug 24 13:55:35 2017 Update passthrough WebGL video expectations for Intel Win10. BUG= 750813 TBR=zmo@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I87195014076fe61ac1a4f8f0d9b0ca94190116e8 Reviewed-on: https://chromium-review.googlesource.com/632516 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#497029} [modify] https://crrev.com/f414b1e5f6ac3f555f6bcaef077937ca372a7d48/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
,
Nov 1 2017
Marking this fixed. More work may be needed on Mac and Android but I will open new bugs for those. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Aug 2 2017