New issue
Advanced search Search tips

Issue 750803 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 750751



Sign in to add a comment

Integrate memory-infra into leveldb MemEnv

Project Member Reported by cmumford@chromium.org, Jul 31 2017

Issue description

When Chromium uses the stock leveldb MemEnv when creating in-memory databases. This implementation does not report memory usage to memory-infra. Create a new Chromium MemEnv that reports to memory-infra.
 
Labels: -Type-Bug Type-Feature
Blocking: 750751
Status: Started (was: Assigned)

Comment 5 by jsb...@chromium.org, Jan 18 2018

Components: -Blink>Storage Internals>Storage
Abandoned?
Resurrected with a new patchset in the review. I think it's ready - or close to it.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d26d10a0ad0c75d5a96f09f7c5677e51faac230

commit 8d26d10a0ad0c75d5a96f09f7c5677e51faac230
Author: Chris Mumford <cmumford@chromium.org>
Date: Fri Apr 20 17:07:58 2018

[leveldb] tracking memory used by in-memory Env's.

leveldb::InMemoryEnv is not exposed with no official support for
calculating memory usage. However, this is a pretty decent estimate
and will be helpful for tracking in-memory Env RAM use.

Bug: 750803
Change-Id: I4e07327bf4480bdb786290c82d8f66412868f36a
Reviewed-on: https://chromium-review.googlesource.com/601207
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552361}
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/PRESUBMIT.py
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/base/trace_event/memory_infra_background_whitelist.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/chrome/browser/sync_file_system/sync_file_system_service_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/components/leveldb_proto/leveldb_database.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/components/leveldb_proto/proto_database_impl_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/components/services/leveldb/leveldb_service_impl.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/components/services/leveldb/leveldb_service_impl.h
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/components/services/leveldb/leveldb_service_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/components/services/leveldb/public/interfaces/leveldb.mojom
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/components/services/leveldb/remote_iterator_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/components/sync/model_impl/model_type_store_backend.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/content/browser/fileapi/browser_file_system_helper.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/content/browser/indexed_db/indexed_db_tombstone_sweeper_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/content/browser/indexed_db/leveldb/leveldb_database.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/content/browser/notifications/notification_database.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/content/browser/service_worker/service_worker_database.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/storage/browser/fileapi/quota/quota_backend_impl_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/third_party/leveldatabase/README.chromium
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/third_party/leveldatabase/env_chromium.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/third_party/leveldatabase/env_chromium.h
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/third_party/leveldatabase/env_chromium_unittest.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/third_party/leveldatabase/leveldb_chrome.cc
[modify] https://crrev.com/8d26d10a0ad0c75d5a96f09f7c5677e51faac230/third_party/leveldatabase/leveldb_chrome.h

Sign in to add a comment