New issue
Advanced search Search tips

Issue 750800 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

SyncFileSystemTest.AuthorizationTest flaky on Linux ChromiumOS

Project Member Reported by michae...@chromium.org, Jul 31 2017

Issue description

There's about 1MB of truncated text before these log lines, followed by dozens of copies of:

[30340:30430:0731/112419.979588:ERROR:sync_task_token.cc(70)] NOTREACHED() hit.

...leading me to believe there may be a LOT of NOTREACHED's hit.

Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=SyncFileSystemTest

Sample failures:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20(1)/builds/50567

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/42386

tzik: could this be a result of 


7f92a72 Remove FILE thread from sync_file_system tests
or
ccd6fb2d Remove SequencedWorkerPool from //chrome/browser/sync_file_system
?
 
The same failure happened again. Disabling the test on ChromiumOS.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de0ef9cf92d3d3454b1781e97cc65ad478306d47

commit de0ef9cf92d3d3454b1781e97cc65ad478306d47
Author: Jan Krcal <jkrcal@chromium.org>
Date: Tue Aug 01 09:22:09 2017

[Sheriff] Disabling SyncFileSystemTest.AuthorizationTest on ChromiumOS

This test is flaky.

TBR=tzik@chromium.org, yutak@chromium.org
NOTRY=true

Bug: 750800
Change-Id: Ie46050f53dab1c328a795658d935b02ac573e1ee
Reviewed-on: https://chromium-review.googlesource.com/595469
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490925}
[modify] https://crrev.com/de0ef9cf92d3d3454b1781e97cc65ad478306d47/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5c6448dc428ce9bb22cc14f8b45bf929cebadd6

commit d5c6448dc428ce9bb22cc14f8b45bf929cebadd6
Author: tzik <tzik@chromium.org>
Date: Wed Aug 02 10:29:49 2017

Remove SyncTaskToken reboot and re-enable disabled SyncFileSystemTest

This CL removes auto-restart of SyncTaskManager. It used to restart
a chain of asynchronous task on an unexpected chaing breakage unless
the browser is in the shutdown sequence. However, as the shutdown
detection is unstable, that causes a restart loop.

Bug: 750800
Change-Id: I2ca231b84908f7c015b4cd97ad02a43f423b20e4
Reviewed-on: https://chromium-review.googlesource.com/597552
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491331}
[modify] https://crrev.com/d5c6448dc428ce9bb22cc14f8b45bf929cebadd6/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
[modify] https://crrev.com/d5c6448dc428ce9bb22cc14f8b45bf929cebadd6/chrome/browser/sync_file_system/drive_backend/sync_task_token.cc

Components: Infra>Flakiness

Sign in to add a comment