emerge dev-install error message is no longer obvious for unknown boards |
||||
Issue descriptionI was adding a new overlay and forgot to add the new board to cros-board.eclass When I started building, the build would fail with a non-obvious error message: " dev-install-0.0.1-r928: >>> Compiling source in /mnt/host/source/src/platform/dev ... dev-install-0.0.1-r928: * Building depgraphs for: virtual/target-os portage virtual/target-os-dev virtual/target-os-test ... dev-install-0.0.1-r928: env: 'emerge-default': No such file or directory dev-install-0.0.1-r928: env: 'emerge-default': No such file or directory dev-install-0.0.1-r928: env: 'emerge-default': No such file or directory dev-install-0.0.1-r928: env: 'emerge-default': No such file or directory dev-install-0.0.1-r928: * ERROR: chromeos-base/dev-install-0.0.1-r928::chromiumos failed (compile phase): dev-install-0.0.1-r928: * ERROR: chromeos-base/dev-install-0.0.1-r928::chromiumos failed (compile phase): dev-install-0.0.1-r928: * ERROR: chromeos-base/dev-install-0.0.1-r928::chromiumos failed (compile phase): dev-install-0.0.1-r928: * ERROR: chromeos-base/dev-install-0.0.1-r928::chromiumos failed (compile phase): dev-install-0.0.1-r928: * `USE="abi_x86_64 amd64 cros-debug elibc_glibc kernel_linux multilib userland_GNU" emerge-default virtual/target-os` failed dev-install-0.0.1-r928: * `USE="abi_x86_64 amd64 cros-debug elibc_glibc kernel_linux multilib userland_GNU" emerge-default portage` failed dev-install-0.0.1-r928: * `USE="abi_x86_64 amd64 cros-debug elibc_glibc kernel_linux multilib userland_GNU" emerge-default virtual/target-os-dev` failed dev-install-0.0.1-r928: * dev-install-0.0.1-r928: * `USE="abi_x86_64 amd64 cros-debug elibc_glibc kernel_linux multilib userland_GNU" emerge-default virtual/target-os-test` failed dev-install-0.0.1-r928: " I initially though it was the chroot that was broken, so recreated it and ran a few time-consuming experiments before figuring out what the problem was. Afaict, https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/chromeos-base/dev-install/dev-install-9999.ebuild#52 now returns "default" instead of an empty string when the board doesn't exist, so the test for failure isn't triggered: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/chromeos-base/dev-install/dev-install-9999.ebuild#54
,
Jul 31 2017
Hi Jason, Can you fix it please? It's a regression introduced by CL:526479
,
Jul 31 2017
Oh, I touched that file so long ago it didn't look familiar. Looks like a simple 25 character change of:
if [[ -z "${BOARD}" ]]; then
to
if [[ -z "${BOARD}" -o "${BOARD} = "default" ]]; then
would give you the behavior you want. I'll try to get to it this week.
,
Jul 31 2017
Thanks!
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7e5c928d53c6692fd1fc109cd3d7eb4ad61adf64 commit 7e5c928d53c6692fd1fc109cd3d7eb4ad61adf64 Author: Jason D. Clinton <jclinton@chromium.org> Date: Fri Aug 04 02:23:19 2017 Make dev-install fail if the board is not known BUG= chromium:750799 TEST=Manually emerge dev-install to ensure the build works/fails as expected. Change-Id: I342958e3fd2e95f7492b2f36678b46ddb5b9e511 Reviewed-on: https://chromium-review.googlesource.com/597009 Commit-Ready: Jason Clinton <jclinton@chromium.org> Tested-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/7e5c928d53c6692fd1fc109cd3d7eb4ad61adf64/chromeos-base/dev-install/dev-install-9999.ebuild
,
Aug 4 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jclinton@chromium.org
, Jul 31 2017