Add UMA statistics for shared leveldb block caches |
||||
Issue descriptionIn addition to shared read block caches, identify other in-memory overhead in need of UMA logging.
,
Jul 31 2017
,
Oct 4 2017
,
Oct 4 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a46073f943a7b0bfee7e884832d43c87bf138025 commit a46073f943a7b0bfee7e884832d43c87bf138025 Author: Chris Mumford <cmumford@chromium.org> Date: Thu Oct 12 21:54:12 2017 leveldb: Tracking shared block caches in UMA. Reporting leveldb shared cache metrics once per UMA ping. Bug: 750798 Change-Id: If49705f6026a3936199f5738ee406fe4e29e0338 Reviewed-on: https://chromium-review.googlesource.com/698377 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#508489} [modify] https://crrev.com/a46073f943a7b0bfee7e884832d43c87bf138025/chrome/browser/metrics/metrics_memory_details.cc [modify] https://crrev.com/a46073f943a7b0bfee7e884832d43c87bf138025/third_party/leveldatabase/env_chromium.cc [modify] https://crrev.com/a46073f943a7b0bfee7e884832d43c87bf138025/third_party/leveldatabase/env_chromium.h [modify] https://crrev.com/a46073f943a7b0bfee7e884832d43c87bf138025/third_party/leveldatabase/leveldb_chrome.cc [modify] https://crrev.com/a46073f943a7b0bfee7e884832d43c87bf138025/third_party/leveldatabase/leveldb_chrome.h [modify] https://crrev.com/a46073f943a7b0bfee7e884832d43c87bf138025/tools/metrics/histograms/histograms.xml
,
Oct 17 2017
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8bb2ba9149776e582473ed72563628a50a67c88 commit f8bb2ba9149776e582473ed72563628a50a67c88 Author: Chris Mumford <cmumford@chromium.org> Date: Wed Oct 18 00:55:38 2017 leveldb: Not logging SharedCache.BytesUsed.InMemory. A bug was not recording LevelDB.SharedCache.BytesUsed.InMemory on small memory devices. However, because the in-memory shared cache size is always zero the correct fix is to simply not record this value. Bug: 750798 Change-Id: Ib5e1188aa857aae6510118bb9ccf27e06ac8c8eb Reviewed-on: https://chromium-review.googlesource.com/723607 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#509636} [modify] https://crrev.com/f8bb2ba9149776e582473ed72563628a50a67c88/third_party/leveldatabase/leveldb_chrome.cc
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4611a2e319faeb3ad9d199fc6a1bb9deaf4e704e commit 4611a2e319faeb3ad9d199fc6a1bb9deaf4e704e Author: Chris Mumford <cmumford@chromium.org> Date: Fri Oct 20 17:05:00 2017 leveldb: Increased limit of LevelDB.SharedCache.BytesUsed. Roughly 25% of the LevelDB.SharedCache.BytesUsed.Browser values were > the limit of UMA_HISTOGRAM_COUNTS_10M. Switching to logging KB and changed name to LevelDB.SharedCache.KBUsed. Bug: 750798 Change-Id: I1c566c06489aaefa5f7bce9da664677b3d19ff6f Reviewed-on: https://chromium-review.googlesource.com/723800 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#510471} [modify] https://crrev.com/4611a2e319faeb3ad9d199fc6a1bb9deaf4e704e/third_party/leveldatabase/leveldb_chrome.cc [modify] https://crrev.com/4611a2e319faeb3ad9d199fc6a1bb9deaf4e704e/tools/metrics/histograms/histograms.xml |
||||
►
Sign in to add a comment |
||||
Comment 1 by cmumford@chromium.org
, Jul 31 2017