New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 750784 link

Starred by 1 user
Status: Fixed
Owner:
█ jbau...@chromium.org
not on Chrome anymore
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

DirectCompositionVideoPixelTest.SRGB* fail on Win10 Intel

Project Member Reported by ynovikov@chromium.org, Jul 31 2017 
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Debug%20%28Intel%20HD%20530%29/builds/1268
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28Intel%20HD%20530%29/builds/1154
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28Intel%20HD%20630%29/builds/244

[ RUN      ] DirectCompositionVideoPixelTest.SRGB
../../gpu/ipc/service/direct_composition_surface_win_unittest.cc(548): error: Value of: AreColorsSimilar(expected_color, actual_color)
  Actual: false
Expected: true
Expected ffd789e0 Actual ffe28fec
[  FAILED  ] DirectCompositionVideoPixelTest.SRGB (1057 ms)
[130/248] DirectCompositionVideoPixelTest.SRGB (1057 ms)
[ RUN      ] DirectCompositionVideoPixelTest.SCRGBLinear
../../gpu/ipc/service/direct_composition_surface_win_unittest.cc(548): error: Value of: AreColorsSimilar(expected_color, actual_color)
  Actual: false
Expected: true
Expected ffd789e0 Actual ffe28fec
[  FAILED  ] DirectCompositionVideoPixelTest.SCRGBLinear (1056 ms)

New test added in https://chromium-review.googlesource.com/c/567580/
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4419a43f1ff0132442de2d8d63abdbfaf9c6751

commit c4419a43f1ff0132442de2d8d63abdbfaf9c6751
Author: John Bauman <jbauman@chromium.org>
Date: Tue Aug 01 21:32:49 2017

Don't check output values for video pixel tests with RGB colorspaces.

If the video processor input is YUV but marked as being in SRGB
colorspace, then NVIDIA treats it more like BT.601 and Intel treats it
more like BT.709. This test only cares that there's no crash, so it
should ignore the precise output color in this case.

Bug:  750784 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I36ce482bfe5cbe79338b485ce5b573e1b170999e
Reviewed-on: https://chromium-review.googlesource.com/595131
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: John Bauman <jbauman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491117}
[modify] https://crrev.com/c4419a43f1ff0132442de2d8d63abdbfaf9c6751/gpu/ipc/service/direct_composition_surface_win_unittest.cc

Comment 2 by jbau...@chromium.org, Aug 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment