New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 750778 link

Starred by 1 user
Status: Fixed
Owner:
wylieb@chromium.org
Closed: Aug 2017
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Fix circular dependency RecursiveFlakePipeline <-> NextBuildNumberPipeline

Project Member Reported by wylieb@chromium.org, Jul 31 2017 
There's a circular dependency here. Only works because they are in the same file. Two pipelines in the same file are really confusing.

Proper behavior of NextBuildNumberPipeline should be the production of a next build number, nothing more.

Factor this out to continue work on fixing the swarming task timeouts.

Comment 1 by wylieb@chromium.org, Jul 31 2017

Summary: [Findit] Flake Analyzer - Fix circular dependency RecursiveFlakePipeline <-> NextBuildNumberPipeline (was: [Findit] Flake Analyzer - Fix circulat dependency RecursiveFlakePipeline <-> NextBuildNumberPipeline)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c

commit 9fada3ab7c1305b20773f5b6afabb6bdf4f1572c
Author: = <wylieb@chromium.org>
Date: Thu Aug 10 19:45:51 2017

[Findit] Flake Analyzer - Factored out NextBuildNumberPipeline.

Continued review from: https://chromium-review.googlesource.com/c/594674.

Bug:  750778 
Change-Id: Ic777d81f89e7f52593e8ea6e80a5e177eb51a0bf
Reviewed-on: https://chromium-review.googlesource.com/606128
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
[modify] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/test/lookback_algorithm_test.py
[add] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/test/flake_analysis_util_test.py
[modify] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
[modify] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/lookback_algorithm.py
[add] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/next_build_number_pipeline.py
[modify] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/flake_constants.py
[modify] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py
[modify] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/test/regression_range_analysis_pipeline_test.py
[add] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/test/next_build_number_pipeline_test.py
[add] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/flake_analysis_util.py
[modify] https://crrev.com/9fada3ab7c1305b20773f5b6afabb6bdf4f1572c/appengine/findit/waterfall/flake/test/recursive_flake_try_job_pipeline_test.py

Comment 3 by wylieb@chromium.org, Aug 11 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment