DevTools: [audits] "Multiple tabs are being controlled" error on youtube.com |
|||||||||
Issue descriptionRepro: Try to audits youtube.com in DevTools Audits panel. You'll get "Multiple tabs are being controlled by the same worker. Close your other tabs on the same origin to audit this page" and it won't let you start auditing. This is reported even when there's just ONE tab. However it appears iframes that point to the same origin are triggering this situation. Basically youtube.com has iframes on it that are also of youtube.com. Issue broken out from https://bugs.chromium.org/p/chromium/issues/detail?id=747245#c17
,
Jul 31 2017
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0d86cf9a6ea4c7601070981e09eed64bfef1e73 commit e0d86cf9a6ea4c7601070981e09eed64bfef1e73 Author: Paul Irish <paulirish@chromium.org> Date: Tue Aug 01 18:46:21 2017 DevTools: De-duplicate service worker's clients Bug: 750767 Change-Id: I7acea758a3142f599326eb745ae16db5f020b06b Reviewed-on: https://chromium-review.googlesource.com/594633 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491063} [modify] https://crrev.com/e0d86cf9a6ea4c7601070981e09eed64bfef1e73/content/browser/devtools/protocol/service_worker_handler.cc
,
Aug 1 2017
,
Aug 2 2017
Tested the issue on Mac OS 10.12.6, Ubuntu 14.04 and Windows 7 using Chrome Canary version M62 - 62.0.3174.0 as per the issue mentioned in original comment. Observed that issue is working as intended ("Multiple tabs are being controlled by the same worker. Close your other tabs on the same origin to audit this page" alert is not displayed when performed audit on www.youtube.com). Hence adding TE-Verified label.
Screenshot attached for reference.
Thank you!
,
Aug 2 2017
Is this require a merge to M61? If so, please request.
,
Aug 2 2017
,
Aug 3 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3 2017
Pls merge you change to M61 branch 3163 by 5:00 PM PT, Friday (08/04) so we can take it in for next week M61 Beta release. Thank you.
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dd186a37dee62bba4744344ebfc24c32e5f9f0d commit 2dd186a37dee62bba4744344ebfc24c32e5f9f0d Author: Paul Irish <paulirish@chromium.org> Date: Thu Aug 03 19:48:48 2017 DevTools: De-duplicate service worker's clients TBR=paulirish@chromium.org (cherry picked from commit e0d86cf9a6ea4c7601070981e09eed64bfef1e73) Bug: 750767 Change-Id: I7acea758a3142f599326eb745ae16db5f020b06b Reviewed-on: https://chromium-review.googlesource.com/594633 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491063} Reviewed-on: https://chromium-review.googlesource.com/600995 Reviewed-by: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#279} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/2dd186a37dee62bba4744344ebfc24c32e5f9f0d/content/browser/devtools/protocol/service_worker_handler.cc
,
Aug 9 2017
Tested the issue on Windows-7,Ubuntu 14.04 and Mac OS 10.12.6 using chrome latest Beta M61-61.0.3163.39 by following steps mentioned in the original comment. Observed that without alerts("Multiple tabs are being controlled") performed Devtools>audit on "youtube.com" working as expected. Hence adding TE-Verified label.
Please find the screen cast(MAC) for reference.
Thank you!
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by paulir...@chromium.org
, Jul 31 2017