New issue
Advanced search Search tips

Issue 750763 link

Starred by 1 user
Status: Fixed
Owner:
cmumford@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 750751



Sign in to add a comment

Consolidate leveldb options in Chromium

Project Member Reported by cmumford@chromium.org, Jul 31 2017 
To help ensure that Chromium is using leveldb in a consistent way, consolidate the creation of all options to a common function. This change shall:

1. Include leveldb::Options, leveldb::ReadOptions,
   and leveldb::WriteOptions.
2. Allow various parts of Chromium to override these
   default option values when appropriate.

Comment 1 by cmumford@chromium.org, Jul 31 2017

Labels: -Type-Bug OS-All Type-Task

Comment 2 by cmumford@chromium.org, Jul 31 2017

Labels: -Type-Task Type-Feature

Comment 3 by cmumford@chromium.org, Jul 31 2017

Blocking: 750751

Comment 4 by cmumford@chromium.org, Aug 2 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b401fd8abd99cd70222722b41b924b2a5c8ed1a6

commit b401fd8abd99cd70222722b41b924b2a5c8ed1a6
Author: Chris Mumford <cmumford@chromium.org>
Date: Wed Aug 09 19:14:25 2017

leveldb: Added leveldb_env::Options.

leveldb_env::Options added to centralize the default leveldb options.
This makes it easier to ensure that databases are being opened with
the optimal settings and to change values for an entire platform if
necessary.

BUG= 750763 

Change-Id: I61d12c382d8274385b36cb051f3ce001589f5de3
Reviewed-on: https://chromium-review.googlesource.com/595051
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493088}
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/chrome/browser/android/history_report/delta_file_backend_leveldb.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/chrome/browser/android/history_report/usage_reports_buffer_backend.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/chrome/browser/sync_file_system/drive_backend/metadata_database.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util_unittest.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/chrome/browser/sync_file_system/local/local_file_change_tracker.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/components/data_reduction_proxy/core/browser/data_store_impl.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/components/drive/resource_metadata_storage.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/components/leveldb/leveldb_service_impl.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/components/leveldb_proto/leveldb_database.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/components/leveldb_proto/leveldb_database.h
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/components/leveldb_proto/proto_database_impl_unittest.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/components/sync/engine/attachments/on_disk_attachment_store.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/components/sync/engine/attachments/on_disk_attachment_store_unittest.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/components/sync/model_impl/model_type_store_backend.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/components/sync/model_impl/model_type_store_backend_unittest.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/content/browser/dom_storage/session_storage_database.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/content/browser/indexed_db/leveldb/leveldb_database.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/content/browser/notifications/notification_database.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/content/browser/service_worker/service_worker_database.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/extensions/browser/value_store/lazy_leveldb.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/extensions/browser/value_store/lazy_leveldb.h
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/google_apis/gcm/engine/gcm_store_impl.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/storage/browser/fileapi/sandbox_directory_database.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/storage/browser/fileapi/sandbox_origin_database.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/third_party/leveldatabase/env_chromium.cc
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/third_party/leveldatabase/env_chromium.h
[modify] https://crrev.com/b401fd8abd99cd70222722b41b924b2a5c8ed1a6/third_party/leveldatabase/env_chromium_unittest.cc

Comment 7 by cmumford@chromium.org, Aug 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment