wprgo "--inject_script=" error |
|||||
Issue description
I am trying to convert jetstream to wprgo and getting an error about "--inject_scripts=" flag when trying to run the converted benchmark.
There seems to a bug in _ReplayCommandLineArgs. When self._make_javascript_deterministic is false the function is adding "--inject_scripts=" flag without adding a script to inject.
I am at chromium revision dd2223 (catapult 9e69c3).
Traceback (most recent call last):
RunBenchmark at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:340
expectations=expectations, metadata=benchmark.GetMetadata())
Run at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:203
_RunStoryAndProcessErrorIfNeeded(story, results, state, test)
_RunStoryAndProcessErrorIfNeeded at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:98
state.WillRunStory(story)
traced_function at /usr/local/google/home/ulan/xrome/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
return func(*args, **kwargs)
WillRunStory at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:224
archive_path, page.make_javascript_deterministic)
traced_function at /usr/local/google/home/ulan/xrome/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
return func(*args, **kwargs)
StartReplay at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/core/network_controller.py:42
make_javascript_deterministic)
StartReplay at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/platform/network_controller_backend.py:215
local_ports = self._StartReplayServer()
_StartReplayServer at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/platform/network_controller_backend.py:240
replay_options=self._ReplayCommandLineArgs())
__init__ at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/util/webpagereplay_go_server.py:86
go_binary_path, http_port, https_port, replay_options, archive_path)
_GetCommandLine at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/util/webpagereplay_go_server.py:117
raise ValueError('Invalid replay options: %s' % replay_options)
ValueError: Invalid replay options: ['--inject_scripts=']
Locals:
archive_path : u'/usr/local/google/home/ulan/xrome/src/tools/perf/page_sets/data/jetstream_000.wprgo'
cmd_line : [u'/usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr']
go_binary_path : u'/usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr'
http_port : 0
https_port : 0
replay_options : ['--inject_scripts=']
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] http://browserbench.org/JetStream/
,
Jul 31 2017
Today's CQ is very flaky. The catapult roll is not in yet: https://chromium-review.googlesource.com/c/595139
,
Aug 1 2017
Catapult roll is landed in r5dc438aca416be722ae65ae09d7521c1ec48b4f4. Thanks for filing the bug.
,
Aug 1 2017
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e9cc4ae40411ece9f938db3f6c2875581a47960 commit 3e9cc4ae40411ece9f938db3f6c2875581a47960 Author: nednguyen <nednguyen@google.com> Date: Tue Aug 01 16:19:10 2017 Run validate_wpr_archives script on PRESUBMIT This script ensures that all WPR archives are correctly checked in cloud storage. Bug:750750 To test this: Patch this CL, modify any .sha1 file in tools/perf/page_sets/data/ arbitrarily. Run "git cl upload" & PRESUBMIT should block. Change-Id: Ic60e339cbf219d45282497a5331ec156b8e208ae Reviewed-on: https://chromium-review.googlesource.com/595877 Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491005} [modify] https://crrev.com/3e9cc4ae40411ece9f938db3f6c2875581a47960/tools/perf/PRESUBMIT.py [add] https://crrev.com/3e9cc4ae40411ece9f938db3f6c2875581a47960/tools/perf/validate_wpr_archives
,
Jan 16
,
Jan 16
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jul 31 2017