New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750750 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 730036



Sign in to add a comment

wprgo "--inject_script=" error

Project Member Reported by u...@chromium.org, Jul 31 2017

Issue description

I am trying to convert jetstream to wprgo and getting an error about "--inject_scripts=" flag when trying to run the converted benchmark.

There seems to a bug in _ReplayCommandLineArgs. When self._make_javascript_deterministic is false the function is adding "--inject_scripts=" flag without adding a script to inject.

I am at chromium revision dd2223 (catapult 9e69c3).

Traceback (most recent call last):
  RunBenchmark at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:340
    expectations=expectations, metadata=benchmark.GetMetadata())
  Run at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:203
    _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
  _RunStoryAndProcessErrorIfNeeded at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:98
    state.WillRunStory(story)
  traced_function at /usr/local/google/home/ulan/xrome/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  WillRunStory at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:224
    archive_path, page.make_javascript_deterministic)
  traced_function at /usr/local/google/home/ulan/xrome/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  StartReplay at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/core/network_controller.py:42
    make_javascript_deterministic)
  StartReplay at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/platform/network_controller_backend.py:215
    local_ports = self._StartReplayServer()
  _StartReplayServer at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/platform/network_controller_backend.py:240
    replay_options=self._ReplayCommandLineArgs())
  __init__ at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/util/webpagereplay_go_server.py:86
    go_binary_path, http_port, https_port, replay_options, archive_path)
  _GetCommandLine at /usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/util/webpagereplay_go_server.py:117
    raise ValueError('Invalid replay options: %s' % replay_options)
ValueError: Invalid replay options: ['--inject_scripts=']

Locals:
  archive_path   : u'/usr/local/google/home/ulan/xrome/src/tools/perf/page_sets/data/jetstream_000.wprgo'
  cmd_line       : [u'/usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr']
  go_binary_path : u'/usr/local/google/home/ulan/xrome/src/third_party/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr'
  http_port      : 0
  https_port     : 0
  replay_options : ['--inject_scripts=']

[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ]  http://browserbench.org/JetStream/
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/963b88b383e0e82b3bf91bc356c8ac54a8bbb1b4

commit 963b88b383e0e82b3bf91bc356c8ac54a8bbb1b4
Author: Helen Li <xunjieli@chromium.org>
Date: Mon Jul 31 23:23:56 2017

[wpr-go] Disable script injection in tools/perf/convert_legacy_wpr_archive

Use '--inject_scripts=', so that the legacy WPR doesn't inject
deterministic.js. Script injection will happen in replay mode when
wpr-go is used.

NOTRY=true # CQ is very flaky and this is a local test script

Bug:  750750 
Change-Id: Ie72b3528131483a86c9427201b6c6cc3fc8233ab
Reviewed-on: https://chromium-review.googlesource.com/594658
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#490819}
[modify] https://crrev.com/963b88b383e0e82b3bf91bc356c8ac54a8bbb1b4/tools/perf/convert_legacy_wpr_archive

Today's CQ is very flaky. The catapult roll is not in yet: https://chromium-review.googlesource.com/c/595139


Status: Fixed (was: Assigned)
Catapult roll is landed in r5dc438aca416be722ae65ae09d7521c1ec48b4f4.
Thanks for filing the bug.
Blocking: 730036
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e9cc4ae40411ece9f938db3f6c2875581a47960

commit 3e9cc4ae40411ece9f938db3f6c2875581a47960
Author: nednguyen <nednguyen@google.com>
Date: Tue Aug 01 16:19:10 2017

Run validate_wpr_archives script on PRESUBMIT

This script ensures that all WPR archives are correctly checked in cloud storage.


Bug:750750

To test this:

Patch this CL, modify any .sha1 file in tools/perf/page_sets/data/ arbitrarily. Run
"git cl upload" & PRESUBMIT should block.

Change-Id: Ic60e339cbf219d45282497a5331ec156b8e208ae
Reviewed-on: https://chromium-review.googlesource.com/595877
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#491005}
[modify] https://crrev.com/3e9cc4ae40411ece9f938db3f6c2875581a47960/tools/perf/PRESUBMIT.py
[add] https://crrev.com/3e9cc4ae40411ece9f938db3f6c2875581a47960/tools/perf/validate_wpr_archives

Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment