Support family-level configuration options |
||
Issue description(note: I'm using the word 'family' instead of board since there is a proposal to change the naming for unified builds) At present in the master configuration we have configuration for individual models but there is no way to specify configuration options which apply to all models with in a family. https://cs.corp.google.com/chromeos_public/src/platform2/chromeos-config/README.md We should add this.
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0f745fceffb8edf1f98506f3ca40f6475dd38581 commit 0f745fceffb8edf1f98506f3ca40f6475dd38581 Author: Simon Glass <sjg@chromium.org> Date: Wed Aug 02 16:13:53 2017 chromeos-config: Add support for family-level configuration Some settings apply to the entire family rather than a particular model. Add a new 'family' node to handle this. Move the firmware 'script' setting there since we don't actually support model-specific firmware update scripts. BUG= chromium:750749 TEST=preview it in retext Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: Ib4cd3156f379dc6bd80bb48741d5b853e89f8333 Reviewed-on: https://chromium-review.googlesource.com/594631 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> Tested-by: Simon Glass <sjg@chromium.org> [modify] https://crrev.com/0f745fceffb8edf1f98506f3ca40f6475dd38581/chromeos-config/README.md
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b7e8453ea528951bbd85c73c13eb7fe2a582b830 commit b7e8453ea528951bbd85c73c13eb7fe2a582b830 Author: Simon Glass <sjg@chromium.org> Date: Thu Aug 03 17:07:57 2017 Add a family configuration node This will be used for family-level configuration, where the setting is the same for all models. Add an empty node and phandle for easy use by .dtsi fragments. BUG= chromium:750749 TEST=emerge-reef-uni -q chromeos-config chromeos-config-bsp \ chromeos-firmware-reef fdtdump /build/reef-uni/usr/share/chromeos-config/config.dtb See that the family {} node appears See that the firmware update package is generated without errors Change-Id: Icd303b6ec620abdb31b99dc2ce438913122be2a9 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/594835 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/b7e8453ea528951bbd85c73c13eb7fe2a582b830/eclass/cros-unibuild.eclass [modify] https://crrev.com/b7e8453ea528951bbd85c73c13eb7fe2a582b830/chromeos-base/chromeos-config/files/skeleton.dts [add] https://crrev.com/b7e8453ea528951bbd85c73c13eb7fe2a582b830/chromeos-base/chromeos-config/chromeos-config-0.0.1-r2.ebuild [rename] https://crrev.com/b7e8453ea528951bbd85c73c13eb7fe2a582b830/chromeos-base/chromeos-config/chromeos-config-0.0.1.ebuild
,
Aug 3 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-reef-private/+/fc92049cf89eb901bc032f18b838019f95bb3ca2 commit fc92049cf89eb901bc032f18b838019f95bb3ca2 Author: Simon Glass <sjg@chromium.org> Date: Thu Aug 03 19:10:08 2017
,
Aug 3 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-coral-private/+/a6672d7165a24bb99ef149e8a3fd6eb4bef4ed93 commit a6672d7165a24bb99ef149e8a3fd6eb4bef4ed93 Author: Simon Glass <sjg@chromium.org> Date: Thu Aug 03 22:13:58 2017
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/c0f44b7f1b927a66671cac502d934141f3680b84 commit c0f44b7f1b927a66671cac502d934141f3680b84 Author: Simon Glass <sjg@chromium.org> Date: Fri Aug 04 22:39:07 2017 pack_firmware: Move the 'script' setting to family config This setting applies to all models so should not be specified indivdually for each model. In fact having a different updater for each model is not currently supported. Further, it is not desirable since it would introduce a difference between models which would complicate testing. Now that we have a family-level configuration node, make use of the setting from there. BUG=b:63822433 BUG= chromium:750749 TEST=PYTHONPATH=~/cosarm python pack_firmware_unittest.py; PYTHONPATH=~/cosarm python pack_firmware_functest.py Change-Id: I1c21ee8665e28764eb7ba4a93de4ac17c1c1f3ff Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/594637 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/c0f44b7f1b927a66671cac502d934141f3680b84/pack_firmware_unittest.py [modify] https://crrev.com/c0f44b7f1b927a66671cac502d934141f3680b84/pack_firmware.py [modify] https://crrev.com/c0f44b7f1b927a66671cac502d934141f3680b84/test/config_base.dtsi
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/fd7e669214188becf67bc99d0fc223a0bd48dc52 commit fd7e669214188becf67bc99d0fc223a0bd48dc52 Author: Simon Glass <sjg@chromium.org> Date: Fri Aug 04 22:39:07 2017 convert_to_model: Update to support family configuration Update this script to output the family configuration for firmware. The only setting is hard-coded for now. BUG= chromium:750749 TEST=PYTHONPATH=~/cosarm python convert_to_model_unittest.py Change-Id: I3e74089c234c1e930ac778a440fc15f887f025ed Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/594836 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/fd7e669214188becf67bc99d0fc223a0bd48dc52/convert_to_model.py [modify] https://crrev.com/fd7e669214188becf67bc99d0fc223a0bd48dc52/convert_to_model_unittest.py
,
Aug 10 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by sjg@chromium.org
, Jul 31 2017Status: Assigned (was: Untriaged)