New issue
Advanced search Search tips

Issue 750741 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Eliminate GetBlockingPool in ios_chrome_large_icon_service_factory.cc

Project Member Reported by steve...@chromium.org, Jul 31 2017

Issue description

This requires removal of |background_task_runner| as an argument to LargIconService.

 
Labels: M-62
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474

commit 06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Aug 03 18:55:38 2017

Elim GetBlockingPool from ios_chrome_large_icon_service_factory

Bug:  750741 
Change-Id: I2e9d55b9e08901d9ac80bd91634936c99831b5b7
Reviewed-on: https://chromium-review.googlesource.com/594640
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491807}
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/chrome/browser/favicon/large_icon_service_factory.cc
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/components/favicon/core/large_icon_service.cc
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/components/favicon/core/large_icon_service.h
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/components/favicon/core/large_icon_service_unittest.cc
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/components/ntp_tiles/icon_cacher_impl_unittest.cc
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/ios/chrome/app/spotlight/BUILD.gn
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/ios/chrome/app/spotlight/spotlight_manager_unittest.mm
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm
[modify] https://crrev.com/06b5e1b67c5fe87edd49dd7c99e6a5c3e09df474/ios/chrome/browser/ui/reading_list/reading_list_mediator_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment