[iOS] Need to revert hack for WKWebView (ios11b3) |
|||||
Issue descriptionApple introduced a bug for iOS 11 beta 3. A WKWebView had to be part of the view hierarchy to work properly. This issue make the sign-in not work properly (issue to fetch tockets in background, see crbug.com/738435 ). This has been fixed with: + crrev.com/c/577807 + crrev.com/c/584878 The extra fix has been merged into M.61 (the main fixe was landed before M-61 branch). + crrev.com/c/589171 This issue has been solved by Apple in iOS 11 beta 4. So this hack has to be reverted. I already reverted it for the top of tree: + crrev.com/c/591671 (main fix + the extra fix) But crrev.com/c/589171 has to be reverted for M.61, too.
,
Jul 31 2017
,
Jul 31 2017
+eugenebut, justincohen as there are other workarounds for this issue in the app
,
Jul 31 2017
Those have been reverted if I'm not mistaken with: crrev.com/c/591671
,
Jul 31 2017
That CL only deals with the account consistency service, and I know we have workarounds in place for preloading and (possibly?) snapshots and likely other places.
,
Jul 31 2017
Sorry, I meant: crrev.com/c/586727
,
Jul 31 2017
Ok cool :-) Carry on :-)
,
Jul 31 2017
,
Aug 1 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/731e8f89b4d1db6fecc2384c3825e95c4d8f206d commit 731e8f89b4d1db6fecc2384c3825e95c4d8f206d Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Aug 01 17:43:49 2017 Revert "iOS 11 WKWebView load is broken" This reverts commit 28dfaa0da2e4ca268f6bbec2ede88c8a8c1933f8. Reason for revert: This appears fixed in Xcode 9 beta 4. Original change's description: > iOS 11 WKWebView load is broken > > In iOS 11, WKWebView has issues (time outs) when loading request if the > view is not part of the hierarchy. The WKWebView is now added to the > hierarchy but off screen. > > Bug: 738435 , 739390 > Change-Id: Ica8584c30a24a11c04658774bd22a77273a93514 > Reviewed-on: https://chromium-review.googlesource.com/577807 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488213} TBR=eugenebut@chromium.org, jlebel@chromium.org, justincohen@chromium.org, msarda@chromium.org, rohitrao@chromium.org (cherry picked from commit 40de2a142623043bb744f808ca5652340b2c00b8) Bug: 750739 , 738435 , 739390 Change-Id: Ic57820325fef5ac86b93b4f02f449b97f0b458e0 Reviewed-on: https://chromium-review.googlesource.com/591671 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Benoit Zanotti <bzanotti@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490743} Reviewed-on: https://chromium-review.googlesource.com/596308 Cr-Commit-Position: refs/branch-heads/3163@{#211} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/731e8f89b4d1db6fecc2384c3825e95c4d8f206d/components/signin/ios/browser/account_consistency_service.mm |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jlebel@chromium.org
, Jul 31 2017