https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%20tester

Started here: https://luci-milo.appspot.com/buildbot/chromium.fyi/ClangToTWin%20tester/8336

Very likely due to https://chromium-review.googlesource.com/576357

[ RUN      ] BufferViewTest.Read
../../chrome/installer/zucchini/buffer_view_unittest.cc(96): error: Death test: buffer.read<uint8_t>(10)
    Result: died but not with expected error.
  Expected: Check failed
Actual msg:
[  DEATH   ] [6240:4028:0728/022257.926:17596507:WARNING:test_suite.cc(235)] Test launcher output path C:\Users\CHROME~2\AppData\Local\Temp\5116_22011\test_results.xml exists. Not adding test launcher result printer.
[  DEATH   ] Backtrace:
[  DEATH   ] 	zucchini::BufferViewTest_Read_Test::TestBody [0x00D8B29C+1244]
[  DEATH   ] 	testing::Test::Run [0x00DB11B3+193]
[  DEATH   ] 	testing::TestInfo::Run [0x00DB1653+213]
[  DEATH   ] 	testing::TestCase::Run [0x00DB1A04+246]
[  DEATH   ] 	testing::internal::UnitTestImpl::RunAllTests [0x00DB577A+602]
[  DEATH   ] 	testing::UnitTest::Run [0x00DB5446+178]
[  DEATH   ] 	base::TestSuite::Run [0x00E0BE61+113]
[  DEATH   ] 	base::LaunchUnitTests [0x00E0C97B+407]
[  DEATH   ] 	base::LaunchUnitTests [0x00E0C858+116]
[  DEATH   ] 	main [0x00E0BD77+95]
[  DEATH   ] 	__scrt_common_main_seh [0x00E582BB+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
[  DEATH   ] 	BaseThreadInitThunk [0x75EC338A+18]
[  DEATH   ] 	RtlInitializeExceptionChain [0x77119902+99]
[  DEATH   ] 	RtlInitializeExceptionChain [0x771198D5+54]
[  DEATH   ]
../../chrome/installer/zucchini/buffer_view_unittest.cc(99): error: Death test: buffer.read<uint32_t>(7)
    Result: died but not with expected error.
  Expected: Check failed
Actual msg:
[  DEATH   ] [5612:5712:0728/022257.964:17596553:WARNING:test_suite.cc(235)] Test launcher output path C:\Users\CHROME~2\AppData\Local\Temp\5116_22011\test_results.xml exists. Not adding test launcher result printer.
[  DEATH   ] Backtrace:
[  DEATH   ] 	zucchini::BufferViewTest_Read_Test::TestBody [0x00D8B42B+1643]
[  DEATH   ] 	testing::Test::Run [0x00DB11B3+193]
[  DEATH   ] 	testing::TestInfo::Run [0x00DB1653+213]
[  DEATH   ] 	testing::TestCase::Run [0x00DB1A04+246]
[  DEATH   ] 	testing::internal::UnitTestImpl::RunAllTests [0x00DB577A+602]
[  DEATH   ] 	testing::UnitTest::Run [0x00DB5446+178]
[  DEATH   ] 	base::TestSuite::Run [0x00E0BE61+113]
[  DEATH   ] 	base::LaunchUnitTests [0x00E0C97B+407]
[  DEATH   ] 	base::LaunchUnitTests [0x00E0C858+116]
[  DEATH   ] 	main [0x00E0BD77+95]
[  DEATH   ] 	__scrt_common_main_seh [0x00E582BB+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
[  DEATH   ] 	BaseThreadInitThunk [0x75EC338A+18]
[  DEATH   ] 	RtlInitializeExceptionChain [0x77119902+99]
[  DEATH   ] 	RtlInitializeExceptionChain [0x771198D5+54]
[  DEATH   ]
[  FAILED  ] BufferViewTest.Read (76 ms)




This is likely the old "in official bots we strip the arg from CHECK(false), so you can't check for death strings there" thing. See e.g. my comments at the bottom of https://codereview.chromium.org/2549093009/ for strategies for dealing with this (including "don't use death tests since they're kind of a pain and often not worth the cost", but others too)


Bug having this fail on clangtot but nowhere else seems weird. I'm going to remove zucchini_unittests from the clang tot bots.