New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750716 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

macOS - Regression: Blinking cursor is to see in front of the URL in the Omnibox, when navigating between NewTabPage and last visit page

Project Member Reported by meh...@chromium.org, Jul 31 2017

Issue description

Chrome Version: Canary Version 62.0.3172.0 
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Open a NewTabPage
(2) Focus the Omnibox and type google.com and press enter
(3) After navigating to google.com click on the arrow back button to navigate back to the NewTabPage
(4) Now navigate forwards again to google.com by clicking on the arrow forward button

What is the expected result?
The Omnibox on google.com should have focus at all. The URL should be completely highlighted.

What happens instead?
You see a blinking cursor at the beginning of the URL.

Please use labels and text to provide additional information.
This is a regression. Works as expected in latest Chrome Stable Version 60.0.3112.78 

Two screencasts are attached.
 
Not_okay.mov
5.0 MB Download
Okay.mov
2.1 MB Download

Comment 1 by shrike@chromium.org, Jul 31 2017

Labels: -Needs-Bisect ReleaseBlock-Stable M-61
Owner: k...@chromium.org
Status: Assigned (was: Untriaged)
Bisect results:

You are probably looking for a change made after 480442 (known good), but no later than 480453 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/8b5035694768d164e3992856d3901664dd9b8ce3..f6e429ff2786b7d1d2c16bd4902fa4b4b9ee5ce5

Suspecting

4033a5a [omnibox] Constrain 'IsSelectAll()' to be more accurate by krb ยท 6 weeks ago

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cda6c9c7ee5274ea800bce409691a15a949fc2c

commit 3cda6c9c7ee5274ea800bce409691a15a949fc2c
Author: Kevin Bailey <krb@chromium.org>
Date: Thu Aug 03 23:20:18 2017

[omnibox] Select-all after revert-all, in more cases

If you look at all the times we call RevertAll(), they either also call
SelectAll(true), or wouldn't mind if we did. We wish to standardize on
this policy. It happens to fix an issue also, where a stale cursor is
produced when tabbing into the Omnibox.

Bug:  735802 ,  750716 
Change-Id: I5aace2b656f4241f2760acadc2a156dbd5fc31f4
Reviewed-on: https://chromium-review.googlesource.com/572206
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491874}
[modify] https://crrev.com/3cda6c9c7ee5274ea800bce409691a15a949fc2c/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/3cda6c9c7ee5274ea800bce409691a15a949fc2c/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
[modify] https://crrev.com/3cda6c9c7ee5274ea800bce409691a15a949fc2c/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/3cda6c9c7ee5274ea800bce409691a15a949fc2c/components/omnibox/browser/omnibox_edit_model.cc

Comment 3 by k...@chromium.org, Aug 7 2017

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
Status: Started (was: Fixed)
Hi krb@ - this fix needs to be merged back to M61.

Comment 6 by k...@chromium.org, Aug 7 2017

Labels: -Merge-TBD Merge-Request-61
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 7 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Before we approve merge to M61, please answer followings:
* Is this M61 regression? Is it critical?
* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M61?
* Any other important details to justify the merge.

Please note M61 is already in Beta, so merge bar is very high. Thank you.
* The changes seem to be minimal, which is good.
* The bug does appear to be fixed in the latest Canary but probably not enough time has elapsed to guarantee against further regressions
* Regressions are undesirable, but the bug is probably not super serious - mehmet@, which is your opinion?
For me, it is okay when we fix it in M62 only without merging back to M61.
Cc: abdulsyed@chromium.org shrike@chromium.org meh...@chromium.org
Labels: -ReleaseBlock-Stable -Merge-Review-61 Merge-Rejected-61
Thank you shrike@ and  mehmet@. 

Removing "ReleaseBlock-Stable" label and rejecting merge to M61 per comment #9 and #10 after discussing with abdulsyed@. 

Please do let us know if there is any concern here. Thank you.


So, can we mark this fixed?
Status: Fixed (was: Started)
I believe so.

Comment 14 by k...@chromium.org, Sep 19 2017

Issue 762552 has been merged into this issue.
I filed the duplicate issue 762552, and while the fix did work temporarily, the issue has resurfaced in the last day.
Please provide more details (Chrome version, etc.).
macOS Sierra 10.12.6
Chrome Version 61.0.3163.100 (Official Build) (64-bit)

Using this extension:
https://chrome.google.com/webstore/detail/new-tab-replace/onpjbfodljecgioajjfdpkficliknajo?hl=en-US
kraskutti@: It is fixed in Chrome 62. 

Sign in to add a comment