Issue metadata
Sign in to add a comment
|
32.5% regression in angle_perftests at 490100:490218 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 31 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8972543339487216176
,
Jul 31 2017
This is because of my CL https://chromium-review.googlesource.com/531798 . Looking.
,
Jul 31 2017
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/23176cead075fae6d43c122ec12c73f91773102e commit 23176cead075fae6d43c122ec12c73f91773102e Author: Jamie Madill <jmadill@chromium.org> Date: Tue Aug 01 00:43:57 2017 Fix performance regression in stream init. Regressed: https://chromium-review.googlesource.com/531798 This was because the std::stringstream constructor was being called every draw call, for the InfoLog of the dynamically recompiled shaders in the D3D back-ends. The constructor was allocating memory and freeing it on destruction. Instead use a lazy init for the std::stringstream in InfoLog like we do for Error. BUG= chromium:750685 Change-Id: I9cd429ae4e1439ae504943a9cad31cbbed17ef32 Reviewed-on: https://chromium-review.googlesource.com/594629 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/23176cead075fae6d43c122ec12c73f91773102e/src/libANGLE/Program.h [modify] https://crrev.com/23176cead075fae6d43c122ec12c73f91773102e/src/libANGLE/Program.cpp
,
Aug 1 2017
=== BISECT JOB RESULTS === Bisect was unable to run to completion Error: INFRA_FAILURE The bisect was able to narrow the range, you can try running with: good_revision: 4c56c607f4caf74e84be768c9b5ae64a058c2ee3 bad_revision : 4c19a8a82b2e93f936ea38c4772ce0182cd3dc2a If failures persist contact the team (see below) and report the error. Bisect Details Configuration: winx64nvidia_perf_bisect Benchmark : angle_perftests Metric : IndexConversionPerfTest_index_range_d3d11/score Revision Result N chromium@490099 62899.5 +- 861.996 6 good chromium@490129 62172.7 +- 323.789 6 good chromium@490144 60063.0 +- 4672.8 6 good chromium@490152 60384.5 +- 5033.21 6 good chromium@490154 64089.3 +- 8697.79 6 good chromium@490155 60855.5 +- 11742.8 6 good chromium@490155,angle@17d270311e 60828.0 +- 1145.35 6 good chromium@490155,angle@4c56c607f4 60498.0 +- 2967.89 6 good chromium@490155,angle@4c19a8a82b 41653.7 +- 5416.61 6 bad chromium@490156 44006.3 +- 2014.5 6 bad chromium@490159 43018.3 +- 411.73 6 bad chromium@490218 44279.7 +- 873.859 6 bad To Run This Test .\src\out\Release_x64\angle_perftests.exe --test-launcher-print-test-stdio=always --test-launcher-jobs=1 More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8972543339487216176 For feedback, file a bug with component Speed>Bisection
,
Aug 1 2017
Simon, this issue is fixed, but I noticed the bisect script had an issue in #6. Anything wrong here or just a flake?
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cb99b0bfc0ea66f7673db9b3a64b982af886c40 commit 4cb99b0bfc0ea66f7673db9b3a64b982af886c40 Author: Geoff Lang <geofflang@chromium.org> Date: Tue Aug 01 21:37:29 2017 Roll ANGLE 40ac783..5788d24 https://chromium.googlesource.com/angle/angle.git/+log/40ac783..5788d24 BUG= chromium:750685 TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9c2a7b8795d7dbe7e7a7c08597f03af846227530 Reviewed-on: https://chromium-review.googlesource.com/596727 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#491119} [modify] https://crrev.com/4cb99b0bfc0ea66f7673db9b3a64b982af886c40/DEPS
,
Aug 1 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/943e77368b8933e8443ee643ec36f4e006de485b commit 943e77368b8933e8443ee643ec36f4e006de485b Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Tue Aug 01 23:14:08 2017 Roll skia/third_party/externals/angle2/ 878c8b1e5..5788d24bb (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/878c8b1e5e89..5788d24bb00c $ git log 878c8b1e5..5788d24bb --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep skia/third_party/externals/angle2 BUG= 750685 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE TBR=liyuqian@google.com Change-Id: Ida46958475127c65133e88eba488d7b5196457d5 Reviewed-on: https://skia-review.googlesource.com/29621 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> [modify] https://crrev.com/943e77368b8933e8443ee643ec36f4e006de485b/DEPS
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21dbe0b2469a39b94d49fe7ea9517b5f9a0ba04d commit 21dbe0b2469a39b94d49fe7ea9517b5f9a0ba04d Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Wed Aug 02 02:27:50 2017 Roll src/third_party/skia/ 5a9a981ed..943e77368 (1 commit) https://skia.googlesource.com/skia.git/+log/5a9a981edf54..943e77368b89 $ git log 5a9a981ed..943e77368 --date=short --no-merges --format='%ad %ae %s' 2017-08-01 skia-deps-roller Roll skia/third_party/externals/angle2/ 878c8b1e5..5788d24bb (2 commits) Created with: roll-dep src/third_party/skia BUG= 750685 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I693087b0232535968ab8ab6de75c890745e51f29 Reviewed-on: https://chromium-review.googlesource.com/596925 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491230} [modify] https://crrev.com/21dbe0b2469a39b94d49fe7ea9517b5f9a0ba04d/DEPS
,
Aug 2 2017
re: #c7 Looks like the bisect hit the 24 hour limit, but the output doesn't reflect that. Blocking on crbug.com/674945
,
Aug 2 2017
Seems to have mostly recovered. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 31 2017