New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750668 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Stacking animations (clicking "a" and backspace repeatedly in the peeking launcher) leads to a lot of animations at the end even after the textbox itself stops changing

Project Member Reported by newcomer@chromium.org, Jul 31 2017

Issue description

Launcher animations are stacking instead of pre-empting.
 P0 for v1
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3b95d688db89d7b1eb44e487fbd21dc8debcc04

commit d3b95d688db89d7b1eb44e487fbd21dc8debcc04
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Aug 03 01:16:20 2017

cros: Fix stacked launcher animations.

In the old version, launching the launcher and then rapidly entering
text and deleting it multiple times caused the scheduled animations to
build up causing the launcher to continue to animate between states long
after text had stopped being entered/removed from the searchbox.

I added a line to stop the current animation before scheduling another
one, which prevents the behavior.

Bug:  750668 
Change-Id: I3134679ad2b378d21c5e953d50ee8909ffdc47fd
Reviewed-on: https://chromium-review.googlesource.com/598743
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491591}
[modify] https://crrev.com/d3b95d688db89d7b1eb44e487fbd21dc8debcc04/ui/app_list/views/app_list_view.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a688fc8f80c9e84c83663016cb316a3793a0cd74

commit a688fc8f80c9e84c83663016cb316a3793a0cd74
Author: Maajid <maajid@chromium.org>
Date: Fri Aug 04 21:13:28 2017

cros: Fix stacked launcher animations.

In the old version, launching the launcher and then rapidly entering
text and deleting it multiple times caused the scheduled animations to
build up causing the launcher to continue to animate between states long
after text had stopped being entered/removed from the searchbox.

I added a line to stop the current animation before scheduling another
one, which prevents the behavior.

TBR=newcomer@chromium.org

(cherry picked from commit d3b95d688db89d7b1eb44e487fbd21dc8debcc04)

Bug:  750668 
Change-Id: I3134679ad2b378d21c5e953d50ee8909ffdc47fd
Reviewed-on: https://chromium-review.googlesource.com/598743
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491591}
Reviewed-on: https://chromium-review.googlesource.com/602521
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#324}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/a688fc8f80c9e84c83663016cb316a3793a0cd74/ui/app_list/views/app_list_view.cc

Status: Fixed (was: Available)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment