Answer cards are coming in blank for certain searches |
||
Issue descriptionP0 for V1 Answer cards for searches "How much wood could a woodchuck chuck" and on "chrome os" and on "smitten" and on "accessibility" result in blank answer cards.
,
Jul 31 2017
Note that the response for those have a "searchanswer-hasresult:false" header, so it's working as intended as far as the server is concerned. Now if the UI still shows a blank space that's a client bug.
,
Jul 31 2017
Hmm I take that back "accessibility" claims to have results but doesn't. Might already be fixed in the newest code but I'll have a look.
,
Jul 31 2017
But regardless, it feels to me like it would be good for the client to hide any card UI if the rendered card has height 0.
,
Jul 31 2017
Makes sense to the Ux team as well! We found this friday afternoon in a bug triage session. shibasheikh@ should know how to repro this.
,
Jul 31 2017
Also please note that P0 is not a traditional P0, we just meant that the team wants it in V1.
,
Jul 31 2017
RE: Comment5. newcomer@, just checking: you talked to UX team, and they liked the idea of comparing the height with 0? I'd prefer not doing this for 2 reasons: 1. We have another mechanism for the server to report empty result - "HasResult" header. Having another check would make bugs in the first mechanism undiscoverable. 2. The height-check is unreliable, as the server in future may decide, for example, to include some decorations, that might be included even for empty cards, and then we are getting all these strange cards back. So I'd prefer to stick to only verifying headers.
,
Jul 31 2017
This should now be fixed at head in google3 (i.e. an empty result from an "answer" type of results won't claim to "have results" in the response headers), it will take a week or so before the fix reaches the production servers.
,
Aug 1 2017
Re #7: UX didn't talk about the technical method of verifying an empty card. Sticking with headers as the method of verification makes sense to me. I guess we will revisit this in a week when the code reaches prod. |
||
►
Sign in to add a comment |
||
Comment 1 by manucornet@chromium.org
, Jul 31 2017