New issue
Advanced search Search tips

Issue 750666 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Remove webstore search results from launcher

Project Member Reported by newcomer@chromium.org, Jul 31 2017

Issue description

P0 for V1 launcher.
 
Owner: newcomer@chromium.org
Update: Omrilio@ requested we do this only for ARC enabled devices. 
https://chromium-review.googlesource.com/c/600527
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a32759c578e9235a916f8830cbc08e440388f93

commit 8a32759c578e9235a916f8830cbc08e440388f93
Author: Alex Newcomer <newcomer@chromium.org>
Date: Wed Aug 09 18:53:18 2017

cros:Peeking Launcher:webstore search

Enable webstore search only when arc is not enabled on the device.

Bug:  750666 
Change-Id: Ib32c99a56b4f7ca6aee2f5e801d0f38aba9aa75d
Reviewed-on: https://chromium-review.googlesource.com/600527
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493077}
[modify] https://crrev.com/8a32759c578e9235a916f8830cbc08e440388f93/chrome/browser/ui/app_list/search/search_controller_factory.cc
[modify] https://crrev.com/8a32759c578e9235a916f8830cbc08e440388f93/components/arc/arc_util.cc
[modify] https://crrev.com/8a32759c578e9235a916f8830cbc08e440388f93/components/arc/arc_util.h

Labels: M-61 Merge-Request-61
Pls apply appropriate OSs. Thank you.

Comment 6 by gov...@chromium.org, Aug 10 2017

Pls apply appropriate OSs. Thank you.
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 10 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by gov...@chromium.org, Aug 11 2017

Labels: OS-Chrome
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge for M61 Chrome OS.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 17 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfb2cacb764cde1e9595934fb1b460c02b91510c

commit cfb2cacb764cde1e9595934fb1b460c02b91510c
Author: Maajid <maajid@chromium.org>
Date: Thu Aug 17 00:21:01 2017

cros:Peeking Launcher:webstore search

Enable webstore search only when arc is not enabled on the device.

TBR=newcomer@chromium.org

(cherry picked from commit 8a32759c578e9235a916f8830cbc08e440388f93)

Bug:  750666 
Change-Id: Ib32c99a56b4f7ca6aee2f5e801d0f38aba9aa75d
Reviewed-on: https://chromium-review.googlesource.com/600527
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493077}
Reviewed-on: https://chromium-review.googlesource.com/618170
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#618}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/cfb2cacb764cde1e9595934fb1b460c02b91510c/chrome/browser/ui/app_list/search/search_controller_factory.cc
[modify] https://crrev.com/cfb2cacb764cde1e9595934fb1b460c02b91510c/components/arc/arc_util.cc
[modify] https://crrev.com/cfb2cacb764cde1e9595934fb1b460c02b91510c/components/arc/arc_util.h

Status: Fixed (was: Assigned)
Cc: dhadd...@chromium.org sdantul...@chromium.org mkarkada@chromium.org abod...@chromium.org
Status: Verified (was: Fixed)
Verified on ChromeOS 9765.49.0, 61.0.3163.72

Webstore search results from launcher do not show up on caroline, elm (ARC++ devices)

Results are seen on peppy (non ARC++ device)

Sign in to add a comment