New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750665 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Search placeholder text should be themed when the sbar is active.

Project Member Reported by newcomer@chromium.org, Jul 31 2017

Issue description

Placeholder text should use the same color as the launcher BG.


 
*only when search box is not selected (non-colored G). Once in colored G, text changes to #000 54%. Sorry I might have said contradictory things in meetings.
Owner: maajid@chromium.org

Comment 3 by maajid@chromium.org, Aug 10 2017

just to clarify based on comment #1:

The placeholder text should be the same colour as the launcher background when the search box is NOT selected (non-coloured G). Then, once the search box is active (coloured G) the text changes to #000 54%. 

This contradicts the original report, so just confirming before I make any changes.
#3 is correct.

Comment 5 by maajid@chromium.org, Aug 11 2017

Status: Fixed (was: Available)
On inspecting the code (and confirming on device) it appears that this has been working as specified since  Issue 737611  was closed and no change is necessary. I've attached two screenshots.

Sebastien, if you can verify on device or clarify, that would be great.
inactive_placeholder_text.png
788 KB View Download
active_placeholder_text.png
789 KB View Download
You are correct. I found another related bug, the background shouldn't be themed when in this mode. I created bug 754567 and assigned to you. Thanks!

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment