New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 750664 link

Starred by 1 user
Status: Archived
Owner:
newcomer@chromium.org
Closed: Aug 2017
Cc:
█ maajid@chromium.org
█ vadimt@chromium.org
shibasheikh@chromium.org
khmel@chromium.org
weidongg@chromium.org
█ warx@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Do not allow launcher to move in side shelf mode

Project Member Reported by newcomer@chromium.org, Jul 31 2017 
Do not allow launcher drag in side shelf mode.
Do not let launcher move in animations for side shelf mode.

Disable all drag at instantiation/OnTabletMode.
Check for tablet mode when closing/opening launcher and instead of shifting
the launcher across the screen, animate opacity.

Opacity shift should be a Tween::EAST_OUT over 300 ms.

P0 for V1

Comment 1 by newcomer@chromium.org, Aug 3 2017

Cc: khmel@chromium.org
Labels: ReleaseBlock-Stable
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 3 2017 

This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 7 2017 

This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a909cdf24d7328a6e14645388e4a5734ff5f82c2

commit a909cdf24d7328a6e14645388e4a5734ff5f82c2
Author: Alex Newcomer <newcomer@chromium.org>
Date: Tue Aug 08 00:41:05 2017

cros: Modify launcher bounds on side shelf.

Modify the launcher bounds in side shelf mode so that the shelf
background is to spec.

cros:Remove launcher movement with side shelf

When the shelf is oriented on the side, the launcher should not move or
be draggable.

Disabled both show and hide animations when side shelf is detected.
Disabled touch drag when side shelf is detected.

Bug:  750664 
Change-Id: Ic48079aa15e1b7d1037b0a9a06b0cb0b55d6ccb6
Reviewed-on: https://chromium-review.googlesource.com/601124
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492473}
[modify] https://crrev.com/a909cdf24d7328a6e14645388e4a5734ff5f82c2/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/a909cdf24d7328a6e14645388e4a5734ff5f82c2/ash/app_list/app_list_presenter_delegate.h
[modify] https://crrev.com/a909cdf24d7328a6e14645388e4a5734ff5f82c2/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/a909cdf24d7328a6e14645388e4a5734ff5f82c2/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/a909cdf24d7328a6e14645388e4a5734ff5f82c2/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc
[modify] https://crrev.com/a909cdf24d7328a6e14645388e4a5734ff5f82c2/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.h
[modify] https://crrev.com/a909cdf24d7328a6e14645388e4a5734ff5f82c2/ui/app_list/presenter/app_list_presenter_delegate.cc
[modify] https://crrev.com/a909cdf24d7328a6e14645388e4a5734ff5f82c2/ui/app_list/presenter/app_list_presenter_delegate.h
[modify] https://crrev.com/a909cdf24d7328a6e14645388e4a5734ff5f82c2/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/a909cdf24d7328a6e14645388e4a5734ff5f82c2/ui/app_list/presenter/app_list_presenter_impl_unittest.cc
[modify] https://crrev.com/a909cdf24d7328a6e14645388e4a5734ff5f82c2/ui/app_list/views/app_list_view.cc

Comment 6 by newcomer@chromium.org, Aug 8 2017

Status: Fixed (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 10 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86323f824ff7cf09dfea0e3911db92279ef914d0

commit 86323f824ff7cf09dfea0e3911db92279ef914d0
Author: Maajid <maajid@chromium.org>
Date: Thu Aug 10 21:20:00 2017

cros: Modify launcher bounds on side shelf.

Modify the launcher bounds in side shelf mode so that the shelf
background is to spec.

cros:Remove launcher movement with side shelf

When the shelf is oriented on the side, the launcher should not move or
be draggable.

Disabled both show and hide animations when side shelf is detected.
Disabled touch drag when side shelf is detected.

TBR=newcomer@chromium.org

(cherry picked from commit a909cdf24d7328a6e14645388e4a5734ff5f82c2)

Bug:  750664 
Change-Id: Ic48079aa15e1b7d1037b0a9a06b0cb0b55d6ccb6
Reviewed-on: https://chromium-review.googlesource.com/601124
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492473}
Reviewed-on: https://chromium-review.googlesource.com/611131
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#462}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/86323f824ff7cf09dfea0e3911db92279ef914d0/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/86323f824ff7cf09dfea0e3911db92279ef914d0/ash/app_list/app_list_presenter_delegate.h
[modify] https://crrev.com/86323f824ff7cf09dfea0e3911db92279ef914d0/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/86323f824ff7cf09dfea0e3911db92279ef914d0/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/86323f824ff7cf09dfea0e3911db92279ef914d0/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc
[modify] https://crrev.com/86323f824ff7cf09dfea0e3911db92279ef914d0/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.h
[modify] https://crrev.com/86323f824ff7cf09dfea0e3911db92279ef914d0/ui/app_list/presenter/app_list_presenter_delegate.cc
[modify] https://crrev.com/86323f824ff7cf09dfea0e3911db92279ef914d0/ui/app_list/presenter/app_list_presenter_delegate.h
[modify] https://crrev.com/86323f824ff7cf09dfea0e3911db92279ef914d0/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/86323f824ff7cf09dfea0e3911db92279ef914d0/ui/app_list/presenter/app_list_presenter_impl_unittest.cc
[modify] https://crrev.com/86323f824ff7cf09dfea0e3911db92279ef914d0/ui/app_list/views/app_list_view.cc

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment