Switching pages while an app is dragging is difficult |
||||||||
Issue descriptionWe should increase the region where when an dragged app lingers, the page switches. In portrait mode launcher this behavior is unintuitive. Also, When at the pagination limit forward the drag events to the app list view drag handler so that the swipes move the widget.
,
Aug 8 2017
Done with other p0 bugs, claim this one.
,
Aug 8 2017
,
Aug 9 2017
+sgabriel@chromium.org Do we have a specs for this? Current page flip zone size is 40px within the border of apps grid view. This works well on old launcher because apps grid view has visible border. But in new launcher the border is not visible. So users do not know where they should drag the app to trigger page switch. One possible solution is to extend the page flip zone outside the apps grid view. It extends to the top of shelf if shelf exists or to the bottom of screen if no shelf exists, what do you think?
,
Aug 10 2017
Recap of off-thread discussion before I deliver specs: - keep 40px zone but increase it below the all apps, all the way to the shelf when possible. This zone should also cover the full width under the all apps container - make hover time to change page from 1000ms to 500ms
,
Aug 10 2017
Thanks, that sounds good.
,
Aug 13 2017
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3835bfc99b6a110a5867175dd534063b703eb08 commit c3835bfc99b6a110a5867175dd534063b703eb08 Author: Weidong Guo <weidongg@chromium.org> Date: Tue Aug 15 22:50:59 2017 cros: Make switching pages easier while dragging app Changes: 1. Extend the page flip zone all the way to the top of shelf if shelf exists or to the bottom of display if shelf does not exist. 2. Change page flip timer to 500ms. BUG= 750660 Change-Id: Ic458dcfb158b42e727c06037ac19006172dfa09b Reviewed-on: https://chromium-review.googlesource.com/612699 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#494582} [modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/app_list_view.h [modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/apps_grid_view.cc [modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/apps_grid_view.h [modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/apps_grid_view_unittest.cc [modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/test/apps_grid_view_test_api.cc [modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/test/apps_grid_view_test_api.h
,
Aug 15 2017
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15d1debec760999b40659183bb2d4bece7afb31e commit 15d1debec760999b40659183bb2d4bece7afb31e Author: Vadim Tryshev <vadimt@google.com> Date: Mon Aug 21 21:36:09 2017 cros: Make switching pages easier while dragging app Changes: 1. Extend the page flip zone all the way to the top of shelf if shelf exists or to the bottom of display if shelf does not exist. 2. Change page flip timer to 500ms. BUG= 750660 TBR=weidongg@chromium.org (cherry picked from commit c3835bfc99b6a110a5867175dd534063b703eb08) Change-Id: Ic458dcfb158b42e727c06037ac19006172dfa09b Reviewed-on: https://chromium-review.googlesource.com/612699 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#494582} Reviewed-on: https://chromium-review.googlesource.com/624800 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#728} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/app_list_view.h [modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/apps_grid_view.cc [modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/apps_grid_view.h [modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/apps_grid_view_unittest.cc [modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/test/apps_grid_view_test_api.cc [modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/test/apps_grid_view_test_api.h
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by newcomer@chromium.org
, Aug 3 2017