New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750660 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: 0
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Switching pages while an app is dragging is difficult

Project Member Reported by newcomer@chromium.org, Jul 31 2017

Issue description

We should increase the region where when an dragged app lingers, the page switches. In portrait mode launcher this behavior is unintuitive.

Also, When at the pagination limit forward the drag events to the app list view drag handler so that the swipes move the widget.
 
Owner: weidongg@chromium.org
Status: Assigned (was: Available)
Done with other p0 bugs, claim this one.
Cc: newcomer@chromium.org
Cc: sgabr...@chromium.org
+sgabriel@chromium.org
Do we have a specs for this?

Current page flip zone size is 40px within the border of apps grid view. This works well on old launcher because apps grid view has visible border. But in new launcher the border is not visible. So users do not know where they should drag the app to trigger page switch.
One possible solution is to extend the page flip zone outside the apps grid view. It extends to the top of shelf if shelf exists or to the bottom of screen if no shelf exists, what do you think?
Recap of off-thread discussion before I deliver specs:

- keep 40px zone but increase it below the all apps, all the way to the shelf when possible. This zone should also cover the full width under the all apps container
- make hover time to change page from 1000ms to 500ms
Thanks, that sounds good.
Labels: -Pri-3 Pri-1
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3835bfc99b6a110a5867175dd534063b703eb08

commit c3835bfc99b6a110a5867175dd534063b703eb08
Author: Weidong Guo <weidongg@chromium.org>
Date: Tue Aug 15 22:50:59 2017

cros: Make switching pages easier while dragging app

Changes:
1. Extend the page flip zone all the way to the top of shelf if shelf
exists or to the bottom of display if shelf does not exist.
2. Change page flip timer to 500ms.

BUG= 750660 

Change-Id: Ic458dcfb158b42e727c06037ac19006172dfa09b
Reviewed-on: https://chromium-review.googlesource.com/612699
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494582}
[modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/apps_grid_view.h
[modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/apps_grid_view_unittest.cc
[modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/test/apps_grid_view_test_api.cc
[modify] https://crrev.com/c3835bfc99b6a110a5867175dd534063b703eb08/ui/app_list/views/test/apps_grid_view_test_api.h

Status: Fixed (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 21 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15d1debec760999b40659183bb2d4bece7afb31e

commit 15d1debec760999b40659183bb2d4bece7afb31e
Author: Vadim Tryshev <vadimt@google.com>
Date: Mon Aug 21 21:36:09 2017

cros: Make switching pages easier while dragging app

Changes:
1. Extend the page flip zone all the way to the top of shelf if shelf
exists or to the bottom of display if shelf does not exist.
2. Change page flip timer to 500ms.

BUG= 750660 
TBR=weidongg@chromium.org

(cherry picked from commit c3835bfc99b6a110a5867175dd534063b703eb08)

Change-Id: Ic458dcfb158b42e727c06037ac19006172dfa09b
Reviewed-on: https://chromium-review.googlesource.com/612699
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494582}
Reviewed-on: https://chromium-review.googlesource.com/624800
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#728}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/apps_grid_view.h
[modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/apps_grid_view_unittest.cc
[modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/test/apps_grid_view_test_api.cc
[modify] https://crrev.com/15d1debec760999b40659183bb2d4bece7afb31e/ui/app_list/views/test/apps_grid_view_test_api.h

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment