New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750658 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Enable touch for pagination indicators on launcher.

Project Member Reported by newcomer@chromium.org, Jul 31 2017

Issue description

Enable touch for pagination indicators on the launcher.

Currently touch is disabled because the indicators are small, we decided that we will enabled touch and at a later date make it more usable by switching pages based on the displacement of the touch event and the active page indicator. For now, just switch to page n when indicator n is clicked.

Keep this bug around for V2 of indicator touch behavior.

P0 for v1.
 
Owner: weidongg@chromium.org
Status: Assigned (was: Available)
It's related to my work, claimed it.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/016663d8bb463ada632b37e5db8ff9fd3819c0d3

commit 016663d8bb463ada632b37e5db8ff9fd3819c0d3
Author: Weidong Guo <weidongg@chromium.org>
Date: Thu Aug 03 03:25:50 2017

Enable touch for pagination indicators on launcher

Changes:
Enable touch event in PageSwitcherButton.

BUG= 750658 

Change-Id: I293544abf5d90201687800d6d6d0451810dfaacd
Reviewed-on: https://chromium-review.googlesource.com/595127
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491629}
[modify] https://crrev.com/016663d8bb463ada632b37e5db8ff9fd3819c0d3/ui/app_list/views/page_switcher_vertical.cc

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 7 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0a71f96e2d8edca2981291f74d6583127529339

commit b0a71f96e2d8edca2981291f74d6583127529339
Author: Maajid <maajid@chromium.org>
Date: Mon Aug 07 21:10:51 2017

Enable touch for pagination indicators on launcher

Changes:
Enable touch event in PageSwitcherButton.

BUG= 750658 
TBR=weidongg@chromium.org

(cherry picked from commit 016663d8bb463ada632b37e5db8ff9fd3819c0d3)

Change-Id: I293544abf5d90201687800d6d6d0451810dfaacd
Reviewed-on: https://chromium-review.googlesource.com/595127
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491629}
Reviewed-on: https://chromium-review.googlesource.com/604492
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#367}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/b0a71f96e2d8edca2981291f74d6583127529339/ui/app_list/views/page_switcher_vertical.cc

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment