"Enable diagnostic packet and event recording" checkbox state forgotten
Reported by
eladalon@webrtc.org,
Jul 31 2017
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Steps to reproduce the problem: 1. Open chrome://webrtc-internals/ 2. Click "Create Dump" 3. Click "Enable diagnostic packet and event recording" 4. Choose an output file 5. Reload the tab or start a new tab What is the expected behavior? The checkbox should be shown as checked. What went wrong? 1. The checkbox is not shown as checked. 2. Trying to check it again fires an RTC_DCHECK (debug builds only). Did this work before? N/A Chrome version: 59.0.3071.115 Channel: stable OS Version: OS X 10.12.6 Flash Version:
,
Aug 2 2017
,
Aug 2 2017
,
Aug 7 2017
,
Aug 8 2017
I had a quick look at this, and this looks like a bug in webrtc-internals. grunell: could you have a look at this? (when you get back from vacation)
,
Aug 17 2017
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/878f9427a2caffe1f5d6f77ab5b5b4b6275b7c70 commit 878f9427a2caffe1f5d6f77ab5b5b4b6275b7c70 Author: Henrik Grunell <grunell@chromium.org> Date: Thu Aug 24 13:08:57 2017 Make sure WebRTC Internals dump checkboxes are marked on load if recording is ongoing. Bug: 750656 Change-Id: Ic745e8346a17fc18224a8fb481215d06a4935e87 Reviewed-on: https://chromium-review.googlesource.com/619208 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#497019} [modify] https://crrev.com/878f9427a2caffe1f5d6f77ab5b5b4b6275b7c70/content/browser/resources/media/dump_creator.js [modify] https://crrev.com/878f9427a2caffe1f5d6f77ab5b5b4b6275b7c70/content/browser/resources/media/webrtc_internals.js [modify] https://crrev.com/878f9427a2caffe1f5d6f77ab5b5b4b6275b7c70/content/browser/webrtc/webrtc_internals_message_handler.cc [modify] https://crrev.com/878f9427a2caffe1f5d6f77ab5b5b4b6275b7c70/content/browser/webrtc/webrtc_internals_message_handler.h
,
Aug 24 2017
,
Aug 25 2017
Verified the fix on the latest canary(62.0.3196.0) on Windows-10, Mac OS 10.12.6 and Linux Ubuntu 14.04. This is working as intended and checkbox remains checked on page reload. Adding the verified label, therefore. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by eostroukhov@chromium.org
, Jul 31 2017