Blank NTP page is displayed on opening QR code |
|||||
Issue descriptionApp Version: 62.0.3168.0 canary iOS Version: 10.3.2 Device : iPhone 6s+,7+ Precondition : 1.Force quit chrome canary to enable “Content suggestions” Steps to reproduce: 1. Launch chrome. 2. Tap on Omnibox. 3. Send the app to background. 4. Hard press on chrome icon > Tap on Scan QR code. 5. Tap on X to close the camera view Observed results: Blank page is displayed Expected results: Fake omnibox,content suggestions and most visited icons should be displayed. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: Not tested, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA,New Feature M62.0.3170.0 canary Bug reproducible on the current beta channel build (App Version, iOS Version): NA,New Feature M62.0.3170.0 canary Link to video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpRHNVbFhuUGg5Tmc/view?usp=sharing
,
Jul 31 2017
Please check this on M60 stable (from App Store). When scanning, a QR code was not scanned and user received a blank screen.
,
Aug 1 2017
I think those are two different problem. The first bug reported is related to ContentSuggestions only, and I am fixing it. I have created crbug.com/751014 to track #2
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0155c20ec4f8ae68dea0aa8aecb4470800dcc19b commit 0155c20ec4f8ae68dea0aa8aecb4470800dcc19b Author: gambard <gambard@chromium.org> Date: Tue Aug 01 14:14:25 2017 Fix ContentSuggestions view after QRCode scan When the QRCode scanner is shown, the current view is removed from the view hierarchy. As ContentSuggestions is using the topLayoutGuide as part of its constraints, the constraint was removed. So when the QRCode scanner is dismissed, the collection has no constraint for its top anchor. This CL fixes it by setting the constraint relative to its superview instead of the top layout guide. It also implements a delegate for the header controller. Bug: 750648 Change-Id: Iccee2279db686ce2e6f3060ed505defbdc038a0b Reviewed-on: https://chromium-review.googlesource.com/595652 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#490987} [modify] https://crrev.com/0155c20ec4f8ae68dea0aa8aecb4470800dcc19b/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/0155c20ec4f8ae68dea0aa8aecb4470800dcc19b/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller_delegate.h [modify] https://crrev.com/0155c20ec4f8ae68dea0aa8aecb4470800dcc19b/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Aug 1 2017
Please, also test by triggering the QRCode scanner from the keyboard accessory (tap the omnibox, above the keyboard you have the voice search icon and the qr code icon).
,
Aug 8 2017
Verified on canary build 62.0.3179.0 on iPhone 7(iOS 10.3.3) and iPhone 6 plus(iOS 11 beta 4) Followed steps as per comment #0 and #5, NTP page is not displaying blank. Looks good |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pmadalla@chromium.org
, Jul 31 2017