Context menu is displayed on long tapping on omnibox in ntp. |
||||||||
Issue descriptionApp Version: 62.0.3168.0 canary iOS Version: 10.3.1, iOS 11 beta 4 Device : iPhone 6s+,7+ Precondition : 1. Force quit chrome canary to enable “Content suggestions” Steps to reproduce: 1. Launch chrome. 2. Tap on omnibox. 3. Scroll content suggestions upwards. 4. Long tap on fake omnibox. Observed results: Context menu is displayed on long tapping on omnibox Expected results: Context menu should not be displayed when tapping on omnibox Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on current stable build (App Version, iOS Version): NA - New implementation on M62.0.3170.0 canary Bug reproducible on the current beta channel build (App Version, iOS Version): NA - New implementation on M62.0.3170.0 canary Link to video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpMGJtYVFWa21DbG8/view?usp=sharing
,
Jul 31 2017
,
Aug 1 2017
Related to ContentSuggestions I think.
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c2b21f8411807f29932c3fde938c5fba2e92640 commit 3c2b21f8411807f29932c3fde938c5fba2e92640 Author: gambard <gambard@chromium.org> Date: Tue Aug 01 13:52:11 2017 Prevent long press trigger on omnibox Long press on the omnibox should not trigger a context menu, regardless of a possible content below it. Bug: 750646 Change-Id: I762dbc144142775636d8fc4818bd225e12dc9c5e Reviewed-on: https://chromium-review.googlesource.com/595628 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#490974} [modify] https://crrev.com/3c2b21f8411807f29932c3fde938c5fba2e92640/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm
,
Aug 1 2017
,
Aug 8 2017
Verified on latest canary 62.0.3179.0 on iPhone 7(iOS 10.3.3) and iPhone 6 plus(iOS 11 beta 5) Issue still exists on following steps mentioned in Comment#0 Link to video: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8T2cwd1pDRVR5ZlU/view?usp=sharing
,
Aug 9 2017
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/728d4bb870e8a27f7924faee4586f07b254dce4e commit 728d4bb870e8a27f7924faee4586f07b254dce4e Author: gambard <gambard@chromium.org> Date: Wed Aug 16 15:05:00 2017 Do not show context menu on omnibox long press When the omnibox is long pressed, the context menu associated with the item located below the omnibox should not be displayed. Bug: 750646 Change-Id: I2662a4bee3390400892b28fa101972e0745d204a Reviewed-on: https://chromium-review.googlesource.com/616144 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#494783} [modify] https://crrev.com/728d4bb870e8a27f7924faee4586f07b254dce4e/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/728d4bb870e8a27f7924faee4586f07b254dce4e/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/728d4bb870e8a27f7924faee4586f07b254dce4e/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
,
Aug 16 2017
,
Aug 22 2017
Verified in 62.0.3193.0 canary, iPhone 6 plus iOS 10.3.3, iPhone 7 iOS11 Looks good. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pkl@chromium.org
, Jul 31 2017Status: Assigned (was: Untriaged)