New issue
Advanced search Search tips

Issue 750642 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task

Blocking:
issue 671355



Sign in to add a comment

Delete dead X11 specific CrOS code

Project Member Reported by kylec...@chromium.org, Jul 31 2017

Issue description

All Chrome OS builds should be using Ozone now. In build targets that are only built for Chrome OS, any code that is guarded by #ifdef USE_X11 or any files that are only included if GN use_x11==true can be deleted.

Similarly, any code that is guarded by #ifdef USE_OZONE probably doesn't need the include guard anymore.

There is lots of related code cleanup where parts of interfaces that only applied to X11 can be deleted too, for example in NativeDisplayDelegate.
 
Blocking: 671355
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb77fe5da00bcf2a64f65925deedb3da574a1b39

commit bb77fe5da00bcf2a64f65925deedb3da574a1b39
Author: Elliot Glaysher <erg@chromium.org>
Date: Wed Aug 02 01:56:46 2017

Delete X11 code in //ash/.

Bug:  750642 
Change-Id: Ibb22a58e8554916190e3e667d65740cf89d7be58
Reviewed-on: https://chromium-review.googlesource.com/596832
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491206}
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/BUILD.gn
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/display/screen_position_controller.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/host/ash_window_tree_host.cc
[delete] https://crrev.com/e929b08cf279a77f17525d88ed85b038f3c5ef7e/ash/host/ash_window_tree_host_x11.cc
[delete] https://crrev.com/e929b08cf279a77f17525d88ed85b038f3c5ef7e/ash/host/ash_window_tree_host_x11.h
[delete] https://crrev.com/e929b08cf279a77f17525d88ed85b038f3c5ef7e/ash/host/ash_window_tree_host_x11_unittest.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/shell_port_classic.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/sticky_keys/sticky_keys_unittest.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/test/ash_test_base.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/touch/touch_hud_debug.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/touch/touch_uma.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/wm/boot_splash_screen_chromeos.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/wm/native_cursor_manager_ash_interactive_uitest.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/wm/native_cursor_manager_ash_unittest.cc
[delete] https://crrev.com/e929b08cf279a77f17525d88ed85b038f3c5ef7e/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc
[delete] https://crrev.com/e929b08cf279a77f17525d88ed85b038f3c5ef7e/ash/wm/tablet_mode/scoped_disable_internal_mouse_and_keyboard_x11.h
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/bb77fe5da00bcf2a64f65925deedb3da574a1b39/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a076f1a9edf32806d0b0dbfff070b5670e19b96

commit 1a076f1a9edf32806d0b0dbfff070b5670e19b96
Author: Elliot Glaysher <erg@chromium.org>
Date: Wed Aug 02 21:34:43 2017

Remove superfluous USE_OZONE guards.

Bug:  750642 
Change-Id: Ib2b7167048a75a3b97e7df80ea21d1ca30ae5b1a
Reviewed-on: https://chromium-review.googlesource.com/598459
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491508}
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/DEPS
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/display/extended_mouse_warp_controller.cc
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/display/unified_mouse_warp_controller.cc
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/display/unified_mouse_warp_controller_unittest.cc
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/host/DEPS
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/host/ash_window_tree_host.h
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/host/ash_window_tree_host_platform.cc
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/host/ash_window_tree_host_platform.h
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/mus/ash_window_tree_host_mus.cc
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/mus/ash_window_tree_host_mus.h
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/shell_delegate.h
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/test_shell_delegate.cc
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/test_shell_delegate.h
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/wm/native_cursor_manager_ash_mus.cc
[modify] https://crrev.com/1a076f1a9edf32806d0b0dbfff070b5670e19b96/ash/wm/native_cursor_manager_ash_mus.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd15fe6331e00a02586b79be48405d6fb1f30a0a

commit dd15fe6331e00a02586b79be48405d6fb1f30a0a
Author: kylechar <kylechar@chromium.org>
Date: Tue Aug 08 15:33:22 2017

Delete X11 code in //ui/display/manager.

There is no more X11 CrOS build. Delete all the unused code code that
was only built for X11. Also remove #if defined(USE_OZONE) guards since
it should always be true now.

There are four tests in TouchTransformControllerTest that use the
framebuffer size as the touchscreen size. I'm not sure this makes sense
with how Ozone handles touchscreens, leave a TODO to come back and take
a closer look at those tests.

Bug:  750642 
Change-Id: I1b29c9e6b1fe5e38b90388bafe2a6c44674c39af
Reviewed-on: https://chromium-review.googlesource.com/600831
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492630}
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/ash/display/window_tree_host_manager.h
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/services/ui/display/screen_manager_ozone_internal.cc
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/services/ui/display/screen_manager_ozone_internal.h
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/ui/display/BUILD.gn
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/ui/display/manager/BUILD.gn
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/ui/display/manager/chromeos/display_configurator.h
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/ui/display/manager/chromeos/touch_transform_controller.cc
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/ui/display/manager/chromeos/touch_transform_controller.h
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/ui/display/manager/chromeos/touch_transform_controller_unittest.cc
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/DEPS
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/display_mode_x11.cc
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/display_mode_x11.h
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/display_snapshot_x11.cc
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/display_snapshot_x11.h
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/display_util_x11.cc
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/display_util_x11.h
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/display_util_x11_unittest.cc
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/native_display_delegate_x11.cc
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/native_display_delegate_x11.h
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/native_display_event_dispatcher_x11.cc
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/native_display_event_dispatcher_x11.h
[delete] https://crrev.com/d4703f78746c0e374cd7cbc05e9fb42bf7b70a2f/ui/display/manager/chromeos/x11/native_display_event_dispatcher_x11_unittest.cc
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/ui/display/manager/display_manager.cc
[modify] https://crrev.com/dd15fe6331e00a02586b79be48405d6fb1f30a0a/ui/display/manager/display_manager.h

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870

commit 0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870
Author: kylechar <kylechar@chromium.org>
Date: Thu Aug 10 05:15:05 2017

Delete dead X11 code from //chrome/browser/chromeos.

There is no more X11 CrOS build. Delete all the unused code code that
was only built for X11. Also remove #if defined(USE_OZONE) guards since
it should always be true now.

Bug:  750642 
Change-Id: Idb1500b05539940b65f30e115fb6de7bc9f59d4d
TBR: jamescook@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/608329
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493249}
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[delete] https://crrev.com/74cabe344138045a60157eecf6f6514de0230c0c/chrome/browser/chromeos/device_uma.cc
[delete] https://crrev.com/74cabe344138045a60157eecf6f6514de0230c0c/chrome/browser/chromeos/device_uma.h
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/chrome/browser/chromeos/events/event_rewriter_unittest.cc
[delete] https://crrev.com/74cabe344138045a60157eecf6f6514de0230c0c/chrome/browser/chromeos/events/system_key_event_listener.cc
[delete] https://crrev.com/74cabe344138045a60157eecf6f6514de0230c0c/chrome/browser/chromeos/events/system_key_event_listener.h
[delete] https://crrev.com/74cabe344138045a60157eecf6f6514de0230c0c/chrome/browser/chromeos/events/xinput_hierarchy_changed_event_listener.cc
[delete] https://crrev.com/74cabe344138045a60157eecf6f6514de0230c0c/chrome/browser/chromeos/events/xinput_hierarchy_changed_event_listener.h
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/chrome/browser/chromeos/policy/status_uploader_unittest.cc
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/chrome/browser/chromeos/system/input_device_settings_impl_ozone.cc
[delete] https://crrev.com/74cabe344138045a60157eecf6f6514de0230c0c/chrome/browser/chromeos/system/input_device_settings_impl_x11.cc
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/chrome/browser/chromeos/system_logs/command_line_log_source.cc
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc
[delete] https://crrev.com/74cabe344138045a60157eecf6f6514de0230c0c/chrome/browser/chromeos/system_logs/touch_log_source_x11.cc
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/ui/base/ime/BUILD.gn
[modify] https://crrev.com/0166bdbcc37c4fc1c6780c3fb5d5ee974b2a2870/ui/base/ime/chromeos/ime_keyboard.h
[delete] https://crrev.com/74cabe344138045a60157eecf6f6514de0230c0c/ui/base/ime/chromeos/ime_keyboard_x11.cc
[delete] https://crrev.com/74cabe344138045a60157eecf6f6514de0230c0c/ui/base/ime/chromeos/ime_keyboard_x11.h

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/324c1137af064eab3cac4021029b0d997e7d7f66

commit 324c1137af064eab3cac4021029b0d997e7d7f66
Author: kylechar <kylechar@chromium.org>
Date: Thu Aug 10 15:02:40 2017

Cleanup methods in NativeDisplayDelegate.

There are a number of methods in the NativeDisplayDelegate interface
that were only used for X11. These methods no longer have any real
implementations, so just remove them entirely. This also involves
cleaning up the DisplayConfigurator and UpdateDisplayConfigurationTask
test expectations.

Note there are more unused methods in NativeDisplayDelegate still. This
is just a manageable subset of them to remove in one CL.

Bug:  750642 
TBR: sandersd@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2eee67871b5217ad055ff8d324746912fd62497f
Reviewed-on: https://chromium-review.googlesource.com/608509
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493389}
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ash/shell.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/extensions/shell/browser/shell_desktop_controller_aura.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/media/gpu/rendering_helper.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/services/ui/display/BUILD.gn
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/services/ui/display/screen_manager_ozone_internal.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/fake_display_delegate.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/fake_display_delegate.h
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/chromeos/display_configurator.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/chromeos/display_configurator.h
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/chromeos/display_configurator_unittest.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/chromeos/test/action_logger_util.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/chromeos/test/action_logger_util.h
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/chromeos/test/test_native_display_delegate.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/chromeos/test/test_native_display_delegate.h
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/chromeos/update_display_configuration_task.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/chromeos/update_display_configuration_task.h
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/chromeos/update_display_configuration_task_unittest.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/forwarding_display_delegate.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/manager/forwarding_display_delegate.h
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/display/types/native_display_delegate.h
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/ozone/demo/ozone_demo.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/ozone/platform/drm/host/drm_native_display_delegate.cc
[modify] https://crrev.com/324c1137af064eab3cac4021029b0d997e7d7f66/ui/ozone/platform/drm/host/drm_native_display_delegate.h

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1066a02fc3eda664375a59a5962ccffa0e28c81f

commit 1066a02fc3eda664375a59a5962ccffa0e28c81f
Author: kylechar <kylechar@chromium.org>
Date: Wed Aug 16 00:57:33 2017

Remove Linux ChromiumOS Ozone Tests (1) json.

All CrOS trybots use Linux ChromiumOS Tests (1) now. Delete the old json
test list and fix a couple divergences in the two lists.

Bug:  750642 
Change-Id: I6c1644c6694f192af339dd460cea59910651f913
Reviewed-on: https://chromium-review.googlesource.com/616011
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494644}
[modify] https://crrev.com/1066a02fc3eda664375a59a5962ccffa0e28c81f/testing/buildbot/chromium.chromiumos.json

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/722abf5f7c3a3aa577377fa9b966a7d453b275e7

commit 722abf5f7c3a3aa577377fa9b966a7d453b275e7
Author: kylechar <kylechar@chromium.org>
Date: Sat Aug 19 00:07:48 2017

Delete ColorCalibrationProfile and related code.

The color calibration profile feature doesn't appear to have ever been
implemented. X11 CrOS had an incomplete implementation at one point but
that code has been deleted and the value goes nowhere.

1. Delete the ColorCalibrationProfile constant and all the plumbing code
   related to it.
2. Deprecate UMA metric ChromeOS.Display.ColorProfile. This metric was
   never used.
3. Delete kDisableDisplayColorCalibration command line flag.

Bug:  750642 ,344728
Change-Id: I9d72556db83cbdf78c782a2537175059e08cc242
Reviewed-on: https://chromium-review.googlesource.com/611623
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495757}
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/chrome/browser/about_flags.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/chrome/browser/chromeos/display/display_preferences.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/chrome/browser/chromeos/display/display_preferences_unittest.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/display_switches.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/display_switches.h
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/fake_display_delegate.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/fake_display_delegate.h
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/manager/chromeos/display_change_observer.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/manager/chromeos/display_configurator.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/manager/chromeos/display_configurator.h
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/manager/chromeos/test/test_native_display_delegate.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/manager/chromeos/test/test_native_display_delegate.h
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/manager/display_manager.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/manager/display_manager.h
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/manager/forwarding_display_delegate.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/manager/forwarding_display_delegate.h
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/manager/managed_display_info.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/manager/managed_display_info.h
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/test/display_manager_test_api.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/test/display_manager_test_api.h
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/types/display_constants.h
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/display/types/native_display_delegate.h
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/ozone/platform/drm/host/drm_native_display_delegate.cc
[modify] https://crrev.com/722abf5f7c3a3aa577377fa9b966a7d453b275e7/ui/ozone/platform/drm/host/drm_native_display_delegate.h

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2

commit 0acbe058ee9565b50bc696dfdc5e4626c27bc3e2
Author: kylechar <kylechar@chromium.org>
Date: Mon Aug 21 21:10:24 2017

Cleanup OS_CHROMEOS && USE_OZONE logic.

If OS_CHROMEOS is true then USE_OZONE is implied now. Cleanup #ifdef
and GN logic. Delete global_shortcut_listener_chromeos.cc/h which is
dead code too.

Bug:  750642 
Change-Id: If9d1f2e95d74b88e7541fa3d3caa793c8c5623d5
Reviewed-on: https://chromium-review.googlesource.com/620529
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496060}
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/chrome/browser/extensions/extension_commands_global_registry_apitest.cc
[delete] https://crrev.com/e5d5eef46f948ec1aa28739ce6fda52e6a673f68/chrome/browser/extensions/global_shortcut_listener_chromeos.cc
[delete] https://crrev.com/e5d5eef46f948ec1aa28739ce6fda52e6a673f68/chrome/browser/extensions/global_shortcut_listener_chromeos.h
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/chrome/test/ppapi/ppapi_browsertest.cc
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/components/exo/wayland/server.cc
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/content/test/ppapi/ppapi_browsertest.cc
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/services/BUILD.gn
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/services/ui/BUILD.gn
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/services/ui/display/BUILD.gn
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/services/ui/public/cpp/input_devices/BUILD.gn
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/services/ui/service.cc
[modify] https://crrev.com/0acbe058ee9565b50bc696dfdc5e4626c27bc3e2/services/ui/ws/platform_display_default.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b4d98eb6cf64b6c5e17047703cfdc0417167a37

commit 5b4d98eb6cf64b6c5e17047703cfdc0417167a37
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Aug 24 05:53:07 2017

Clean up the use of USE_X11 and OS_CHROMEOS in gpu/

Now that we ChromeOS has switched over to ozone, the combination
USE_X11 && !OS_CHROMEOS is redundant.

This is a driven by CL that cleans it up in gpu/.

BUG= 750642 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1e190ba086dd37f35c96c6f476383d99bbe41003
Reviewed-on: https://chromium-review.googlesource.com/629107
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496962}
[modify] https://crrev.com/5b4d98eb6cf64b6c5e17047703cfdc0417167a37/gpu/config/gpu_info.cc
[modify] https://crrev.com/5b4d98eb6cf64b6c5e17047703cfdc0417167a37/gpu/config/gpu_info.h
[modify] https://crrev.com/5b4d98eb6cf64b6c5e17047703cfdc0417167a37/gpu/config/gpu_info_collector.cc
[modify] https://crrev.com/5b4d98eb6cf64b6c5e17047703cfdc0417167a37/gpu/ipc/common/gpu_info_struct_traits.cc
[modify] https://crrev.com/5b4d98eb6cf64b6c5e17047703cfdc0417167a37/gpu/ipc/common/gpu_info_struct_traits.h
[modify] https://crrev.com/5b4d98eb6cf64b6c5e17047703cfdc0417167a37/gpu/ipc/common/gpu_param_traits_macros.h
[modify] https://crrev.com/5b4d98eb6cf64b6c5e17047703cfdc0417167a37/gpu/ipc/common/struct_traits_unittest.cc
[modify] https://crrev.com/5b4d98eb6cf64b6c5e17047703cfdc0417167a37/gpu/tools/compositor_model_bench/BUILD.gn

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961

commit 9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Aug 24 21:34:45 2017

Clean up the use of USE_X11 and OS_CHROMEOS in chrome/

Now that we ChromeOS has switched over to ozone, the combination
USE_X11 && !OS_CHROMEOS is redundant.

This is a driven by CL that cleans it up in chrome/.

BUG= 750642 

Change-Id: Ia19b0b72a0a623c6b4fe739ad8a20f9d910e8bb7
Reviewed-on: https://chromium-review.googlesource.com/629110
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#497195}
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/browser/extensions/extension_commands_global_registry_apitest.cc
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/browser/media/webrtc/native_desktop_media_list.cc
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/browser/password_manager/password_store_factory.cc
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/browser/themes/theme_service_factory.cc
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/browser/ui/browser_view_prefs.cc
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/browser/ui/views/frame/browser_frame.cc
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/test/BUILD.gn
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/test/base/interactive_ui_tests_main.cc
[modify] https://crrev.com/9fab4ea8614c6b5da5bb3d6cc20a3f64a057a961/chrome/test/base/view_event_test_platform_part_default.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea8becb61a659343e12e8866bf435b5a25d22339

commit ea8becb61a659343e12e8866bf435b5a25d22339
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Aug 24 21:48:44 2017

Clean up the use of USE_X11 and OS_CHROMEOS in ui/

Now that we ChromeOS has switched over to ozone, the combination
USE_X11 && !OS_CHROMEOS is redundant.

This is a driven by CL that cleans it up in ui/.

BUG= 750642 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iac4cffc97f8907020ea0959ce881f3f34ffabc41
Reviewed-on: https://chromium-review.googlesource.com/632636
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#497200}
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/aura/mus/os_exchange_data_provider_mus.cc
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/aura/mus/os_exchange_data_provider_mus.h
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/base/BUILD.gn
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/base/dragdrop/os_exchange_data.h
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/base/dragdrop/os_exchange_data_provider_factory.cc
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/gfx/native_widget_types.h
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/views/BUILD.gn
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/views/corewm/tooltip_controller_unittest.cc
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/views/test/views_test_base.cc
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/views/test/widget_test_aura.cc
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/ea8becb61a659343e12e8866bf435b5a25d22339/ui/views/widget/widget_unittest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65af68d4fd0d32358d9fd50c36c69c326a4e75a4

commit 65af68d4fd0d32358d9fd50c36c69c326a4e75a4
Author: kylechar <kylechar@chromium.org>
Date: Fri Aug 25 21:11:04 2017

Delete DisplaySnapshotMojo.

Now that DisplaySnapshotX11 is gone, DisplaySnapshot doesn't need to be
an abstract class. None of the implementations of DisplaySnapshot are
actually different. Delete DisplaySnapshotMojo and replace all usage of
it with DisplaySnapshot. Everything basically just works, including the
StructTraits, with a few minor syntax changes.

Remove the abstract DisplaySnapshot::ToString() function and replace it
with the implementation from FakeDisplaySnapshot. The Ozone DRM
implementation was always an empty string on device, which makes the log
statements that print it less than useful, so this should be a
positive change.

Bug:  750642 
Change-Id: Ie994957b0313c885e505d852111ddf867de07a68
Reviewed-on: https://chromium-review.googlesource.com/629047
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497534}
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/services/ui/display/screen_manager_forwarding.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/fake_display_snapshot.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/fake_display_snapshot.h
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/manager/chromeos/display_change_observer_unittest.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/manager/forwarding_display_delegate.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/manager/forwarding_display_delegate.h
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/mojo/BUILD.gn
[rename] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/mojo/display_snapshot.mojom
[add] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/mojo/display_snapshot.typemap
[delete] https://crrev.com/6bea2b874a2d86dbd166e37c7d61ee3b61415901/ui/display/mojo/display_snapshot_mojo.typemap
[delete] https://crrev.com/6bea2b874a2d86dbd166e37c7d61ee3b61415901/ui/display/mojo/display_snapshot_mojo_struct_traits.h
[rename] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/mojo/display_snapshot_struct_traits.cc
[add] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/mojo/display_snapshot_struct_traits.h
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/mojo/display_struct_traits_unittest.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/mojo/native_display_delegate.mojom
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/mojo/typemaps.gni
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/types/BUILD.gn
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/types/display_snapshot.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/display/types/display_snapshot.h
[delete] https://crrev.com/6bea2b874a2d86dbd166e37c7d61ee3b61415901/ui/display/types/display_snapshot_mojo.cc
[delete] https://crrev.com/6bea2b874a2d86dbd166e37c7d61ee3b61415901/ui/display/types/display_snapshot_mojo.h
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/common/display_snapshot_proxy.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/common/display_snapshot_proxy.h
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/common/gpu/ozone_gpu_message_params.h
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/common/gpu/ozone_gpu_messages.h
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/platform/drm/common/display_types.h
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/platform/drm/common/drm_util.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/platform/drm/common/drm_util_unittest.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/platform/drm/mus_thread_proxy.cc
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/platform/drm/mus_thread_proxy.h
[modify] https://crrev.com/65af68d4fd0d32358d9fd50c36c69c326a4e75a4/ui/ozone/public/interfaces/gpu_adapter.mojom

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6

commit 5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Aug 30 22:15:56 2017

Clean up the use of USE_X11 and OS_CHROMEOS in content/

Now that we ChromeOS has switched over to ozone, the combination
USE_X11 && !OS_CHROMEOS is redundant.

This is a driven by CL that cleans it up in content/.

BUG= 750642 

Change-Id: If7d66ebbe3e316fbe22b06bf19785b631ce70254
Reviewed-on: https://chromium-review.googlesource.com/642330
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#498637}
[modify] https://crrev.com/5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6/content/browser/browser_main_loop.cc
[modify] https://crrev.com/5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6/content/browser/browser_main_loop.h
[modify] https://crrev.com/5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6/content/browser/gpu/gpu_internals_ui.cc
[modify] https://crrev.com/5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/5986d9bcad44375dcbf6ea7f2ddd9679995ce4b6/content/renderer/webclipboard_impl.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a7574f4de05cd229f5285681f32c6d530d54a12

commit 6a7574f4de05cd229f5285681f32c6d530d54a12
Author: kylechar <kylechar@chromium.org>
Date: Wed Aug 30 22:27:12 2017

Cleanup CrOS code in video_decode_accelerator_unittest.

Remove unnecessary code and #ifdefs. There is no more X11 CrOS build, so
there is no USE_X11 and OS_CHROMEOS combination. Similarly, if
OS_CHROMEOS then USE_OZONE must be true. Delete X11 specific code,
cleanup #ifdefs and logic. Also don't use the framebuffer size as window
size, since framebuffer was an X11 specific concept.

Bug:  750642 
Test: Ran video_decode_accelerator_unittest on link.
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iad74d171a6dced2aa3b28d9a9e656c8371fb1317
Reviewed-on: https://chromium-review.googlesource.com/643337
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498644}
[modify] https://crrev.com/6a7574f4de05cd229f5285681f32c6d530d54a12/media/gpu/rendering_helper.cc
[modify] https://crrev.com/6a7574f4de05cd229f5285681f32c6d530d54a12/media/gpu/rendering_helper.h
[modify] https://crrev.com/6a7574f4de05cd229f5285681f32c6d530d54a12/media/gpu/video_decode_accelerator_unittest.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e

commit 59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e
Author: kylechar <kylechar@chromium.org>
Date: Thu Aug 31 01:24:04 2017

Remove X11 functions from NativeDisplayDelegate.

Remove AddMode() and SetFramebufferSize() from NativeDisplayDelegate.
These functions are no longer used and have no implementations. Also
remove code that setup the framebuffer size, since the value isn't used.

Bug:  750642 
Change-Id: Icc02b05ebb6e99df188039d7c9f7990fa2879fa8
Reviewed-on: https://chromium-review.googlesource.com/641944
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498700}
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/fake_display_delegate.cc
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/fake_display_delegate.h
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/display_configurator.cc
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/display_configurator.h
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/display_configurator_unittest.cc
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/display_layout_manager.h
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/test/action_logger_util.cc
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/test/action_logger_util.h
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/test/test_display_layout_manager.cc
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/test/test_display_layout_manager.h
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/test/test_native_display_delegate.cc
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/test/test_native_display_delegate.h
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/update_display_configuration_task.cc
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/update_display_configuration_task.h
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/chromeos/update_display_configuration_task_unittest.cc
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/forwarding_display_delegate.cc
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/manager/forwarding_display_delegate.h
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/display/types/native_display_delegate.h
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/ozone/platform/drm/host/drm_native_display_delegate.cc
[modify] https://crrev.com/59a635e9ae8e407db70b9c6001b6a9a9e8d3a43e/ui/ozone/platform/drm/host/drm_native_display_delegate.h

Owner: kylec...@chromium.org
Status: Started (was: Available)
I think that's pretty much all the low hanging fruit for code cleanup.
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/925d8cd983ceb0b5a0498e2504c08ee181523e9f

commit 925d8cd983ceb0b5a0498e2504c08ee181523e9f
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Tue Sep 12 17:09:29 2017

chromeos: Remove some left over x11 code.

chromeos always builds with ozone, and no longer has direct dependency on
x11. So USE_X11 is no longer applicable for chromeos code.

BUG= 750642 

Change-Id: Iade4e609dbbb5d20d7a683153d23f84fc7848b46
Reviewed-on: https://chromium-review.googlesource.com/663403
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501320}
[modify] https://crrev.com/925d8cd983ceb0b5a0498e2504c08ee181523e9f/ui/chromeos/events/BUILD.gn
[modify] https://crrev.com/925d8cd983ceb0b5a0498e2504c08ee181523e9f/ui/chromeos/events/event_rewriter_chromeos.cc
[modify] https://crrev.com/925d8cd983ceb0b5a0498e2504c08ee181523e9f/ui/chromeos/events/event_rewriter_chromeos.h

Status: Fixed (was: Started)
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a49b8cd9edbd6892ce977cbfc7e9754d4f7debc

commit 7a49b8cd9edbd6892ce977cbfc7e9754d4f7debc
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Fri Sep 29 01:48:07 2017

Clean up the use of USE_X11 in ui/keyboard.

ChromeOS has switched over to ozone.

Bug:  750642 
Test: Build passes.
Change-Id: Iffaf5f2b6d18fc05a6fa29fa22c7d16f2132497d
Reviewed-on: https://chromium-review.googlesource.com/689874
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505250}
[modify] https://crrev.com/7a49b8cd9edbd6892ce977cbfc7e9754d4f7debc/ui/keyboard/keyboard_controller.cc

Comment 22 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 23 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment