Issue 750639 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	sullivan@chromium.org
Closed:	Sep 19
Components:	Speed>Metrics
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug

Measure time from user input to Navigation Start

Project Member Reported by tdres...@chromium.org, Jul 31 2017

Issue description

Our page load metrics (First Paint, First Contentful Paint, Time To Interactive, Time to Interactive, etc) all measure from NavigationStart.

However, there's some amount of time between when the user clicks a link, or hits enter in the omnibox, until we hit NavigationStart.

Let's add a metric for this.

Comment 1 by tdres...@chromium.org, Nov 23 2017

This is definitely important - hopefully we'll get to this in Q1?

Comment 2 by dproy@chromium.org, Mar 15 2018

Owner: dproy@chromium.org

Comment 3 by dproy@chromium.org, Mar 16 2018

Labels: -progressivewebmetrics

Comment 4 by npm@chromium.org, Jun 27 2018

Any update on this?

Comment 5 by tdres...@chromium.org, Jun 27 2018

Owner: sullivan@chromium.org
Status: Assigned (was: Available)

Comment 6 by sullivan@chromium.org, Jul 13

Status: Started (was: Assigned)

I started a doc on this here: https://docs.google.com/document/d/1sAaPCsvxF19l1fgGcxW-SouxVwwcQ4rsz4md4jjq2Gs/edit#

Still several questions to answer before starting code.

Comment 7 by sullivan@chromium.org, Aug 3

Ended up writing a second doc when implementing the first piece: https://docs.google.com/document/d/1dkjlbAQXdeXlnAwYFP7ueAIfO84DnQJ9U01krXv4x3s/edit

Will merge them together at some point, but second one is most useful for reviewing CLs:

https://chromium-review.googlesource.com/c/chromium/src/+/1162673
https://chromium-review.googlesource.com/c/chromium/src/+/1155470

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3aaa8a38193d1a0558f08d1bb00fcc888a811cf

commit a3aaa8a38193d1a0558f08d1bb00fcc888a811cf
Author: Annie Sullivan <sullivan@chromium.org>
Date: Tue Aug 14 19:23:45 2018

Add UMA histogram to measure how long beforeunload dialogs are open.

This is part of a larger project to measure page load times starting
at user input. One blocker for this is understanding how the
beforeunload dialog might affect this metric.

Bug:  750639 
Change-Id: I7aef267a52353a6852dd82bad6c6c74a6fb82e51
Reviewed-on: https://chromium-review.googlesource.com/1162673
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582992}
[modify] https://crrev.com/a3aaa8a38193d1a0558f08d1bb00fcc888a811cf/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/a3aaa8a38193d1a0558f08d1bb00fcc888a811cf/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a

commit 91f9186b1e58eba678c1e7fe511b0ed832bc3e8a
Author: Annie Sullivan <sullivan@chromium.org>
Date: Tue Aug 21 18:33:56 2018

Add UMA histograms to measure user input to navigation and paint.

To start, the histograms are only recorded when the input is the user
clicking a link in a web page. New types of input will be added over
time.

A doc explaining this CL is here: https://docs.google.com/document/d/1dkjlbAQXdeXlnAwYFP7ueAIfO84DnQJ9U01krXv4x3s/edit?usp=sharing

Bug:  750639 
Change-Id: Id883b391a9fa1eaca97d4d8f606fe62a9e09bbca
Reviewed-on: https://chromium-review.googlesource.com/1155470
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584855}
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[add] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/chrome/test/data/page_load_metrics/link.html
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/common/frame_messages.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/common/navigation_params.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/common/navigation_params.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/public/browser/navigation_handle.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/renderer/render_frame_impl.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/shell/test_runner/web_frame_test_client.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/shell/test_runner/web_frame_test_proxy.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/content/shell/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/public/web/web_navigation_timings.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/public/web/web_performance.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/exported/web_document_subresource_filter_test.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/exported/web_performance.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/loader/document_load_timing.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/loader/document_load_timing.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/loader/frame_loader.h
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/timing/performance_timing.cc
[modify] https://crrev.com/91f9186b1e58eba678c1e7fe511b0ed832bc3e8a/third_party/blink/renderer/core/timing/performance_timing.h

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea2c938669eddf2dfd5037ab9cf46c605dd4fc66

commit ea2c938669eddf2dfd5037ab9cf46c605dd4fc66
Author: Annie Sullivan <sullivan@chromium.org>
Date: Wed Aug 22 19:35:01 2018

Add entries for InputTo* page load metrics to histograms.xml.

This is a follow up to
https://chromium-review.googlesource.com/c/chromium/src/+/1155470
where the code to report the metrics was added.

Bug:  750639 
Change-Id: Ib2ed87109d04837560bb6768020765e6d7183e8e
Reviewed-on: https://chromium-review.googlesource.com/1184969
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585200}
[modify] https://crrev.com/ea2c938669eddf2dfd5037ab9cf46c605dd4fc66/tools/metrics/histograms/histograms.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c4449bafb87598c511829e3d39f754cbecb6cd0

commit 9c4449bafb87598c511829e3d39f754cbecb6cd0
Author: Annie Sullivan <sullivan@chromium.org>
Date: Wed Aug 22 23:43:56 2018

Add InputToNavigation UMA break downs by input type.

This is part of a larger project to extend page load timings to
include the time from user input to navigation. This CL makes it
possible to see different input types separately. See the last
section of the design doc:
https://docs.google.com/document/d/1dkjlbAQXdeXlnAwYFP7ueAIfO84DnQJ9U01krXv4x3s/edit#


Bug:  750639 
Change-Id: Ia37e5fe0bad25d5428f4c34d41292e660bd6d281
Reviewed-on: https://chromium-review.googlesource.com/1183587
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585310}
[modify] https://crrev.com/9c4449bafb87598c511829e3d39f754cbecb6cd0/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/9c4449bafb87598c511829e3d39f754cbecb6cd0/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/9c4449bafb87598c511829e3d39f754cbecb6cd0/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/9c4449bafb87598c511829e3d39f754cbecb6cd0/tools/metrics/histograms/histograms.xml

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6a7883547f2e92a7ec27814e9cfe373fd34df82

commit e6a7883547f2e92a7ec27814e9cfe373fd34df82
Author: Annie Sullivan <sullivan@chromium.org>
Date: Mon Aug 27 22:30:49 2018

Pass base::TimeTicks by value for input_start.

This is cleanup from
https://chromium-review.googlesource.com/c/chromium/src/+/1155470

Changes base::TimeTicks to be passed by value for input_start, and also
for the navigation_start arguments in the same methods.

Bug:  750639 
Change-Id: If6e6dcb09046142c727b6254532a18801ad72c90
Reviewed-on: https://chromium-review.googlesource.com/1187519
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586450}
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/content/common/navigation_params.cc
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/content/common/navigation_params.h
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/content/public/browser/navigation_handle.h
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/content/renderer/render_frame_impl.h
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/content/shell/test_runner/web_frame_test_client.h
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/content/shell/test_runner/web_frame_test_proxy.cc
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/content/shell/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/third_party/blink/renderer/core/exported/web_document_subresource_filter_test.cc
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/e6a7883547f2e92a7ec27814e9cfe373fd34df82/third_party/blink/renderer/core/loader/frame_loader.h

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d3c6398a2b1827b530b106e7bf738922696b280

commit 0d3c6398a2b1827b530b106e7bf738922696b280
Author: Annie Sullivan <sullivan@chromium.org>
Date: Tue Sep 04 14:55:47 2018

Add InputTo* page load metrics from desktop omnibox.

This CL records the event timestamps for mouse click and enter keypress
in the desktop omnibox, and passes them through to
CommonNavigationParams, which are used to generate InputTo* page load
metrics.

Doc covering this work in more detail:
https://docs.google.com/document/d/1sAaPCsvxF19l1fgGcxW-SouxVwwcQ4rsz4md4jjq2Gs/edit

Bug:  750639 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I92a48fa69413f8163756b3b7289335b898b9849e
Reviewed-on: https://chromium-review.googlesource.com/1178624
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588513}
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/browser_focus_uitest.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/browser_navigator.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/browser_navigator_params.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/location_bar/location_bar.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/views/omnibox/omnibox_result_view.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/test/base/test_browser_window.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/test/base/test_browser_window.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/chrome/test/base/ui_test_utils.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/components/omnibox/browser/omnibox_edit_controller.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/components/omnibox/browser/omnibox_edit_controller.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/components/omnibox/browser/omnibox_edit_model.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/components/omnibox/browser/omnibox_view.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/components/omnibox/browser/omnibox_view.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/components/omnibox/browser/test_omnibox_view.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/content/browser/frame_host/navigation_controller_impl.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/content/public/browser/navigation_controller.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/ios/chrome/browser/ui/omnibox/web_omnibox_edit_controller_impl.h
[modify] https://crrev.com/0d3c6398a2b1827b530b106e7bf738922696b280/ios/chrome/browser/ui/omnibox/web_omnibox_edit_controller_impl.mm

Comment 14 Deleted

Comment 15 Deleted

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d01cb75f831ceb0d6e0b877b39aae211a2971e57

commit d01cb75f831ceb0d6e0b877b39aae211a2971e57
Author: Annie Sullivan <sullivan@chromium.org>
Date: Tue Sep 04 17:34:28 2018

Record InputTo* page load timings from Android omnibox.

This is part of a larger project to extend Chrome's page load timings
so that they start at user input. Doc on this part:
https://docs.google.com/document/d/1HuWl1Vg7d_5XX2tsEDI79f-LtEspoYxv4b0gmII0bnw/edit#

Bug:  750639 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Change-Id: I97217311088a85025e77f44d718d3df8f1328f76
Reviewed-on: https://chromium-review.googlesource.com/1171209
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588572}
[modify] https://crrev.com/d01cb75f831ceb0d6e0b877b39aae211a2971e57/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/d01cb75f831ceb0d6e0b877b39aae211a2971e57/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxResultsAdapter.java
[modify] https://crrev.com/d01cb75f831ceb0d6e0b877b39aae211a2971e57/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
[modify] https://crrev.com/d01cb75f831ceb0d6e0b877b39aae211a2971e57/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java
[modify] https://crrev.com/d01cb75f831ceb0d6e0b877b39aae211a2971e57/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/d01cb75f831ceb0d6e0b877b39aae211a2971e57/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/d01cb75f831ceb0d6e0b877b39aae211a2971e57/chrome/browser/android/tab_android.h
[modify] https://crrev.com/d01cb75f831ceb0d6e0b877b39aae211a2971e57/content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0045fe4474b27b1383af0b38a60a82fa87edf66

commit c0045fe4474b27b1383af0b38a60a82fa87edf66
Author: Annie Sullivan <sullivan@chromium.org>
Date: Wed Sep 19 15:42:59 2018

Track InputTo* paint metrics from clicks handled by JavaScript.

Doc with background info: https://docs.google.com/document/d/1yg7wiWwYbd5hybJfHJC1aCZlOH7E8AR1f93IA71eU3I/edit#

Bug:  750639 
Change-Id: Ifccd618c0e44f297f54b0c0bc3792f565eb47be9
Reviewed-on: https://chromium-review.googlesource.com/1226518
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592415}
[modify] https://crrev.com/c0045fe4474b27b1383af0b38a60a82fa87edf66/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[add] https://crrev.com/c0045fe4474b27b1383af0b38a60a82fa87edf66/chrome/test/data/page_load_metrics/javascript_href.html
[add] https://crrev.com/c0045fe4474b27b1383af0b38a60a82fa87edf66/chrome/test/data/page_load_metrics/javascript_window_open.html
[modify] https://crrev.com/c0045fe4474b27b1383af0b38a60a82fa87edf66/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/c0045fe4474b27b1383af0b38a60a82fa87edf66/third_party/blink/renderer/core/page/create_window.cc

Comment 18 by sullivan@chromium.org, Sep 19

Status: Fixed (was: Started)

This is done. Note  bug 750639  for UKM still needs to be implemented.

Comment 19 by sullivan@chromium.org, Sep 19

Whoops, that's bug 886860 for the UKM.

►

Issue 750639 link

Issue metadata

Measure time from user input to Navigation Start

Issue description

Comment 1 by tdres...@chromium.org, Nov 23 2017

Comment 1 Deleted

Comment 2 by dproy@chromium.org, Mar 15 2018

Comment 2 Deleted

Comment 3 by dproy@chromium.org, Mar 16 2018

Comment 3 Deleted

Comment 4 by npm@chromium.org, Jun 27 2018

Comment 4 Deleted

Comment 5 by tdres...@chromium.org, Jun 27 2018

Comment 5 Deleted

Comment 6 by sullivan@chromium.org, Jul 13

Comment 6 Deleted

Comment 7 by sullivan@chromium.org, Aug 3

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Aug 14

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Aug 21

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Aug 22

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Aug 22

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Aug 27

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Sep 4

Comment 13 Deleted

Comment 14 Deleted

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Sep 5

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Sep 19

Comment 17 Deleted

Comment 18 by sullivan@chromium.org, Sep 19

Comment 18 Deleted

Comment 19 by sullivan@chromium.org, Sep 19

Comment 19 Deleted

Sign in to add a comment