Omnibox is corrupted on long pressing most popular site or content suggestion and changing the device orientation. |
||||
Issue descriptionApp Version: 62.0.3170.0 Canary iOS Version: 10.3.3, 11 beta 4 Device: iPhones only URL: Chrome -- NTP Precondition: Force quit chrome canary to enable “Content suggestions” Steps to reproduce: 1. Launch chrome canary in portrait or landscape orientation 2. Scroll up NTP. 3. Long press on most popular or content suggestion. 4. Rotate the device to landscape or portrait orientation. 5. Tap on “Cancel” on context menu. Observed results: Notice that the omnibox is corrupted or displayed half Expected results: Omnibox should be at right place and properly displayed. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: On rotating the device context menu disappears at Step 4 Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA - New implementation on M62 Bug reproducible on the current beta channel build (App Version, iOS Version): NA - New implementation on M62 Link to video/image: https://drive.google.com/a/google.com/file/d/0Bz2uwV55gGwDZ05vaFozdnp2OU0/view?usp=sharing
,
Jul 31 2017
Omnibox displayed over page content.
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ec680becbc61f72eb6ae3e3354bc6fd229b8ce8 commit 1ec680becbc61f72eb6ae3e3354bc6fd229b8ce8 Author: gambard <gambard@chromium.org> Date: Tue Aug 01 13:04:31 2017 Update fake omnibox width on rotation When rotating the device, the omnibox width should be set to the new width. This width computation needs to take into account the y offset of the collection and its new size. So the calculation needs to be started from the collection. Bug: 750637 Change-Id: I14dc8f878b815f7f32bd33f88691e9b39782e0d4 Reviewed-on: https://chromium-review.googlesource.com/595741 Reviewed-by: Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#490956} [modify] https://crrev.com/1ec680becbc61f72eb6ae3e3354bc6fd229b8ce8/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/1ec680becbc61f72eb6ae3e3354bc6fd229b8ce8/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Aug 1 2017
The bug was also reproducible without triggering a context menu, just with the omnibox scrolled to top.
,
Aug 8 2017
Verified on latest canary 62.0.3179.0 on iPhone7(iOS 10.3.3) and iPhone 6Plus(iOS 11 beta4) Followed steps of Comment#0. Looks good, the omnibox width is scaling to new size. |
||||
►
Sign in to add a comment |
||||
Comment 1 by vbarig...@chromium.org
, Jul 31 2017