New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 750636 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

GLIF voice search icon on NTP is not functional

Project Member Reported by vbarig...@chromium.org, Jul 31 2017

Issue description

App Version:  62.0.3170.0 Canary
iOS Version: 10.3.3, 11 beta 4
Device: iPhone, iPad
URL: Chrome -- GLIF

Precondition:
Force quit chrome canary to enable “Content suggestions”

Steps to reproduce:
  1.  1.  Launch chrome canary
  2.  Tap on GLIF voice search icon on NTP.
 
Observed results:
GLIF voice search icon is not functional.

Expected results:
GLIF voice search icon should be functional.

Note 1: On iPads, GLIF icon present only in fake omnibox is not working.  
Note2: Working fine in chrome canary 60.0.3169.0

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): NA - New implementation on M62
Bug reproducible on the current beta channel build (App Version, iOS Version): NA - New implementation on M62

Link to video/image: https://drive.google.com/a/google.com/file/d/0Bz2uwV55gGwDOGJHVkhDN2pISEk/view?usp=sharing
 
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7daedbc14b1a7b892a157ed497bc4d59d098d3f1

commit 7daedbc14b1a7b892a157ed497bc4d59d098d3f1
Author: gambard <gambard@chromium.org>
Date: Mon Jul 31 13:55:37 2017

Add dispatcher for VoiceSearch commands

During the removal of the VoiceSearch commands, ContentSuggestions was
forgotten. This CL uses the new API to start voice search with the
dispatcher.

Bug:  750636 
Change-Id: Ie1cb80f0beb2969868a565c2c60c0df564c10bc8
Reviewed-on: https://chromium-review.googlesource.com/593660
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490759}
[modify] https://crrev.com/7daedbc14b1a7b892a157ed497bc4d59d098d3f1/ios/chrome/app/startup/setup_debugging.mm
[modify] https://crrev.com/7daedbc14b1a7b892a157ed497bc4d59d098d3f1/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h
[modify] https://crrev.com/7daedbc14b1a7b892a157ed497bc4d59d098d3f1/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.h
[modify] https://crrev.com/7daedbc14b1a7b892a157ed497bc4d59d098d3f1/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified the issue on the build 62.0.3179.0 tested on iPhone7+(iOS 11 beta 4) and iPhone5(10.3.3), iPad Air(10.3.2).

Tapping on GLIF icon is functional works fine.

Sign in to add a comment