New issue
Advanced search Search tips

Issue 750625 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 750684
Owner: ----
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT import] git cl upload -f -t failed on TestExpectations lint

Project Member Reported by foolip@chromium.org, Jul 31 2017

Issue description

https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/401
https://chromium-review.googlesource.com/c/593218/

This import failed in lint:

Traceback (most recent call last):
  File "/mnt/data/b/rr/tmpMU0ywB/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in <module>
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmpMU0ywB/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 125, in main
    if not self.update_expectations_for_cl():
  File "/mnt/data/b/rr/tmpMU0ywB/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 167, in update_expectations_for_cl
    self._upload_patchset(message)
  File "/mnt/data/b/rr/tmpMU0ywB/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 390, in _upload_patchset
    self.git_cl.run(['upload', '-f', '-t', message, '--gerrit'])
  File "/mnt/data/b/rr/tmpMU0ywB/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 51, in run
    return self._host.executive.run_command(command, cwd=self._cwd)
  File "/mnt/data/b/rr/tmpMU0ywB/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 339, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/mnt/data/b/rr/tmpMU0ywB/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 247, in default_error_handler
    raise error
webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'cl', 'upload', '-f', '-t', 'Update test expectations and baselines.', '--gerrit']" exit_code: 1
output: Last 500 characters of output:
b-tchinese/big5/big5-encode-href.html on lines third_party/WebKit/LayoutTests/TestExpectations:1895 and third_party/WebKit/LayoutTests/TestExpectations:1896 match overlapping sets of configurations. external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href.html
Lint failed.

This is a bit strange, because TestExpectations didn't change, only WPT_BASE_MANIFEST.json.
 
Mergedinto: 750684
Status: Duplicate (was: Untriaged)
It was failing when trying to upload the second patchset which contained changes to TestExpectations, because it tried to add "Android" to different expectation lines for the same test; I just filed  bug 750684  before seeing this one.

Sign in to add a comment